Further changes from code review

- Remove STACK_SIZE override, and instead use Emscripten default of 64KB
- Change INITIAL_HEAP to 64KB

Signed-off-by: Michael Warres <[email protected]>

Author: mpwarres

Makefile

@@ -34,7 +34,7 @@ WASM_LIBS = $(shell $(PKG_CONFIG) $(WASM_DEPS) $(PROTO_DEPS) \
 EMSCRIPTEN_LINK_OPTS := --no-entry \
 	--js-library ${PROXY_WASM_CPP_SDK}/proxy_wasm_intrinsics.js \
 	-sSTANDALONE_WASM -sEXPORTED_FUNCTIONS=_malloc \
-	-sALLOW_MEMORY_GROWTH=1 -sSTACK_SIZE=256KB -sINITIAL_HEAP=1MB
+	-sALLOW_MEMORY_GROWTH=1 -sINITIAL_HEAP=64KB
 
 
 debug-deps:

bazel/defs.bzl

@@ -102,14 +102,8 @@ def proxy_wasm_cc_binary(
             "-sEXPORTED_FUNCTIONS=_malloc",
             # Allow allocating memory past initial heap size
             "-sALLOW_MEMORY_GROWTH=1",
-            # Total stack size (fixed). Emscripten default stack size changed from 5MiB to 64KiB in
-            # 3.1.27: https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md,
-            # https://github.com/emscripten-core/emscripten/pull/18191. We pick 256KB as a balance
-            # between reducing memory size and providing more headroom in case of deeper call
-            # stacks. For comparison, the Rust SDK uses 1MB stack by default.
-            "-sSTACK_SIZE=256KB",
-            # Initial amount of heap memory
-            "-sINITIAL_HEAP=1MB",
+            # Initial amount of heap memory. 64KB matches Rust SDK starting heap size.
+            "-sINITIAL_HEAP=64KB",
         ],
         tags = tags + [
             "manual",