Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Developing with this theme" README text #36

Closed
zipymonkey opened this issue Apr 5, 2024 · 1 comment · Fixed by #55
Closed

Update "Developing with this theme" README text #36

zipymonkey opened this issue Apr 5, 2024 · 1 comment · Fixed by #55
Assignees
@zipymonkey

Comments

@zipymonkey
Copy link
Collaborator

zipymonkey commented Apr 5, 2024 •
edited
Loading

There is a ddev develop-theme command in the new site template. The README instructions should be updated to include these instructions:

ddev develop-theme;
ddev theme-build;
ddev drush cr;

Add a section for reviewing how a specific feature branch impacts a site and subtheme:

ddev composer require psu-libraries/psulib_base:dev-17-basic-theme-footer;
ddev theme-build;
@zipymonkey zipymonkey self-assigned this Apr 17, 2024
zipymonkey added a commit that referenced this issue Apr 17, 2024
@zipymonkey
Issue #36 - Updating the README.md to use ddev for theme development.…
d89afe2 
… Updating how the subtheme should be used... this section is still WIP.
@zipymonkey zipymonkey linked a pull request Apr 17, 2024 that will close this issue
Issue #36 - Updating the README.md to use ddev for theme development.… #55
Merged
zipymonkey added a commit that referenced this issue Apr 17, 2024
@zipymonkey
Issue #36 - Removing duplicate steps for generating the subtheme.
22c046b
zipymonkey added a commit that referenced this issue Apr 18, 2024
@zipymonkey
Merge pull request #55 from psu-libraries/36-update-developing-with-t…
15d173e 
…his-theme-readme-text

Issue #36 - Updating the README.md to use ddev for theme development.…
@zipymonkey zipymonkey reopened this Apr 18, 2024
@zipymonkey
Copy link
Collaborator Author

Why did I re-open this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zipymonkey zipymonkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #36 - Updating the README.md to use ddev for theme development.… psu-libraries/psulib_base
1 participant
@zipymonkey