Skip to content

Mc/here now with limit #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 20, 2025
Merged

Mc/here now with limit #374

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
53b8ffd
Test
marcin-cebo Sep 17, 2025
f5d4c6a
Test
marcin-cebo Sep 17, 2025
82bd6e6
Initial changes
marcin-cebo Sep 25, 2025
da02d30
Added integration tests
marcin-cebo Oct 3, 2025
ba34ae8
Renamed nextStartFrom to nextOffset
marcin-cebo Oct 6, 2025
49864fc
Renamed startFrom to offset
marcin-cebo Oct 6, 2025
0baebf7
Updated snippets
marcin-cebo Oct 6, 2025
dc78bd8
Added log statement for case when limit is out of allowed range.
marcin-cebo Oct 6, 2025
49c6b3d
Added test for Global HereNow
marcin-cebo Oct 6, 2025
e3d916d
Added integration tests for java
marcin-cebo Oct 6, 2025
4994a7e
Rename variables
marcin-cebo Oct 6, 2025
99a1f77
Fix lint
marcin-cebo Oct 7, 2025
38a97a4
Fix JS
marcin-cebo Oct 7, 2025
83a5dc3
Improved paging in snippets.
marcin-cebo Oct 7, 2025
eb4d1b7
Allowed limit to be 0
marcin-cebo Oct 8, 2025
00be4a9
Channel data are returned for one channel when includeUUIDs=false to …
marcin-cebo Oct 11, 2025
4454939
Removed nextOffset
marcin-cebo Oct 14, 2025
8d3c6c3
Updated kDoc
marcin-cebo Oct 14, 2025
9d33842
Fix
marcin-cebo Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ub-gson/pubnub-gson-api/src/main/java/com/pubnub/api/java/endpoints/presence/HereNow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,8 @@ public interface HereNow extends Endpoint<PNHereNowResult> {
HereNow includeState(boolean includeState);

HereNow includeUUIDs(boolean includeUUIDs);

HereNow limit(int limit);

HereNow offset(Integer offset);
}
58 changes: 45 additions & 13 deletions pubnub-gson/pubnub-gson-docs/src/main/java/com/pubnub/docs/presence/HereNowApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,61 @@ public static void main(String[] args) throws PubNubException {

PubNub pubnub = PubNub.create(configBuilder.build());

// Get presence information for specified channels
// Get presence information for specified channels with pagination support
pubnub.hereNow()
.channels(Arrays.asList("coolChannel", "coolChannel2"))
.includeUUIDs(true)
.limit(100)
.async(result -> {
result.onSuccess((PNHereNowResult res) -> {
printHereNowResult(res);

System.out.println("Total Channels: " + res.getTotalChannels());
System.out.println("Total Occupancy: " + res.getTotalOccupancy());

for (PNHereNowChannelData channelData : res.getChannels().values()) {
System.out.println("---");
System.out.println("Channel: " + channelData.getChannelName());
System.out.println("Occupancy: " + channelData.getOccupancy());
System.out.println("Occupants:");
for (PNHereNowOccupantData occupant : channelData.getOccupants()) {
System.out.println("UUID: " + occupant.getUuid() + " State: " + occupant.getState());
}
// Check if more results are available
if (res.getNextOffset() != null) {
System.out.println("\nMore results available. Fetching next page...\n");

// Fetch next page using the offset from previous response
pubnub.hereNow()
.channels(Arrays.asList("coolChannel", "coolChannel2"))
.includeUUIDs(true)
.limit(100)
.offset(res.getNextOffset())
.async(result2 -> {
result2.onSuccess((PNHereNowResult res2) -> {
printHereNowResult(res2);

// Continue pagination if needed by checking res2.getNextOffset()
}).onFailure((PubNubException exception) -> {
System.out.println("Error retrieving hereNow data: " + exception.getMessage());
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it make sense / possible to create local closure which will be called from initial and nested hereNow calls, but in addition to result will pass offset for example and inside if it is not nil, make another hereNow calls - it will give user better idea because novice may think that it is ok to nest hereNow calls as long as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I will modify this code.

}
}).onFailure( (PubNubException exception) -> {
}).onFailure((PubNubException exception) -> {
System.out.println("Error retrieving hereNow data: " + exception.getMessage());
});
});
}

/**
* Helper method to print HereNow presence information
*/
private static void printHereNowResult(PNHereNowResult result) {
System.out.println("Total Channels: " + result.getTotalChannels());
System.out.println("Total Occupancy: " + result.getTotalOccupancy());

for (PNHereNowChannelData channelData : result.getChannels().values()) {
System.out.println("---");
System.out.println("Channel: " + channelData.getChannelName());
System.out.println("Occupancy: " + channelData.getOccupancy());
System.out.println("Occupants:");
for (PNHereNowOccupantData occupant : channelData.getOccupants()) {
System.out.println("UUID: " + occupant.getUuid() + " State: " + occupant.getState());
}
}

if (result.getNextOffset() != null && result.getNextOffset() != 0) {
System.out.println("Next Offset: " + result.getNextOffset());
}
}
}
// snippet.end
Loading
Loading