Plugin name confusion when installing with composer

[valarauco]

Hi! Thank you for this awesome plugin!

I have recently switched the installation of this plugin to use composer instead of "manual" method.
I ran composer require radialapps/banner-warn, as indicated in README and Packagist.
My composer.json has this line

        "radialapps/banner-warn": "^1.2",

But when the plugin is installed, it's located under plugins/banner_warn/ and yet configuration stays banner-warn.
Also, main plugin's file is named banner_warn.php which conflicts with banner-warn naming.
This results in an error from RC trying to load the plugin.

[pulsejet]

Hmm, it's not supposed to matter AFAIK. As long as your config looks something like this

$config['plugins'] = [
        ...
        'banner_warn',
];

Maybe something changed upstream ...

[valarauco]

No, after running composer, config file is set to:

$config['plugins'] = [
        ...
        'banner-warn',
]

I have to manually rewrite it with the underscore. It could be something with composer but not sure, I'm not expert on composer nor PHP.

[melroy89]

No, after running composer, config file is set to:

$config['plugins'] = [
        ...
        'banner-warn',
]

I have to manually rewrite it with the underscore. It could be something with composer but not sure, I'm not expert on composer nor PHP.

Yes, this is because the folder name is banner_warn in the plugins directory. I bet this is a mistake by the plugin installer script.