Skip to content

Potential Race Condition when using Update Objects with TTL #1060

@lichtie

Description

@lichtie

What happened?

When an update's TTL expires before the stack controller has a chance to update its status, it gets an error (the object has been modified; please apply your changes to the latest version.) because the resource has been updated and neglects to clean up the finalizer, leaving the update orphaned.

Ideally, the stack controller would see the new resourceVersion and clean up the finalizer

Example

Relevant sections of the code: https://github.com/pulumi/pulumi-kubernetes-operator/blob/12fed433d473ecb75f73da08[…]3043755e/operator/internal/controller/auto/update_controller.go
https://github.com/pulumi/pulumi-kubernetes-operator/blob/master/operator/internal/controller/pulumi/stack_controller.go#L590-L592

Output of pulumi about

On version 2.3.0

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSome behavior is incorrect or out of spec

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions