Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on SSA preview is incorrect #3067

Open
rquitales opened this issue Jun 24, 2024 · 1 comment
Open

Documentation on SSA preview is incorrect #3067

rquitales opened this issue Jun 24, 2024 · 1 comment
Labels
area/docs Improvements or additions to documentation kind/documentation Improvements or additions to documentation

Comments

@rquitales
Copy link
Member

What happened?

https://www.pulumi.com/registry/packages/kubernetes/how-to-guides/managing-resources-with-server-side-apply/#prerequisites

The above documentation implies that a provider with SSA enabled will always perform an input diff (which is what's done for a provider configured to use CSA). This is incorrect as a SSA enabled provider will always perform a server-side dry-run for preview. The following are scenarios of when client-side or server-side dry-run is used:

Server-side dry-run:

  • Kubernetes provider with enableServerSideApply set to true

Client-side dry-run (ie. input diff);

  • Kubernetes provider with enableServerSideApply set to false
  • Kubernetes provider with enableServerSideApply set to true AND server-side dry-run fails due to lack of PATCH permissions

Example

Output of pulumi about

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@rquitales rquitales added area/docs Improvements or additions to documentation kind/documentation Improvements or additions to documentation labels Jun 24, 2024
@EronWright
Copy link
Contributor

EronWright commented Oct 16, 2024

Note also that the CSA-to-SSA migration logic doesn't take effect during a preview, and this may lead to spurious "conflict" messages during preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation kind/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants