(PE-42492) Use dnf on fedora >= 41

On Fedora 41, `yum` is a symlink to dnf5, which doesn't accept -d:

    Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y update puppet-agent-8.15.0.9.g6d2fce25b' returned 2: Unknown argument "-d" for command "dnf5". Add "--help" for more information about the arguments.

Puppet's dnf provider was updated to support dnf5 in PA-7414, see
puppetlabs/puppet-private@0d932d327ef, but that doesn't help if the provider is
explicitly set to `yum`.

Author: joshcooper

manifests/install.pp

@@ -93,7 +93,11 @@
         # any other type of source means we use a package manager (yum) with no 'source' parameter in the
         # package resource below
         $_package_version = $package_version
-        $_provider = 'yum'
+        if $facts['os']['name'] == 'Fedora' and versioncmp($facts['os']['release']['major'], '41') {
+          $_provider = 'dnf'
+        } else {
+          $_provider = 'yum'
+        }
         $_source = undef
       }
     }

spec/classes/puppet_agent_spec.rb

@@ -119,6 +119,26 @@ def global_facts(facts, os)
     end
   end
 
+  context 'package provider' do
+    # module is still pinned to older rspec-puppet and facterdb
+    os = 'fedora-41-x86_64'
+    facts = {
+      os => on_supported_os['fedora-39-x86_64'],
+    }
+    facts.values.first[:os]['release'] = {'full'=>'41', 'major'=>'41'}
+    facts.each do |os, facts|
+      context "on #{os}" do
+        let(:facts) do
+          global_facts(facts, os)
+        end
+
+        let(:params) { { package_version: '6.18.0' } }
+
+        it { is_expected.to contain_package('puppet-agent').with_provider('dnf') }
+      end
+    end
+  end
+
   context 'supported_operating systems' do
     on_supported_os.each do |os, facts|
       context "on #{os}" do