feat: use FilePath instead of String where needed, AutodetectLink

Author: srghma

src/Node/FS.purs

@@ -12,6 +12,8 @@ module Node.FS
 
 import Prelude
 
+import Data.Nullable (Nullable)
+import Data.Nullable as Nullable
 import Node.FS.Constants (FileFlags(..), fileFlagsToNode) as Exports
 
 foreign import data FileDescriptor :: Type
@@ -23,19 +25,21 @@ type BufferOffset = Int
 type ByteCount = Int
 
 -- | Symlink varieties.
-data SymlinkType = FileLink | DirLink | JunctionLink
+data SymlinkType = FileLink | DirLink | JunctionLink | AutodetectLink
 
 -- | Convert a `SymlinkType` to a `String` in the format expected by the
 -- | Node.js filesystem API.
-symlinkTypeToNode :: SymlinkType -> String
+symlinkTypeToNode :: SymlinkType -> Nullable String
 symlinkTypeToNode ty = case ty of
-  FileLink -> "file"
-  DirLink -> "dir"
-  JunctionLink -> "junction"
+  FileLink -> Nullable.notNull "file"
+  DirLink -> Nullable.notNull "dir"
+  JunctionLink -> Nullable.notNull "junction"
+  AutodetectLink -> Nullable.null
 
 instance showSymlinkType :: Show SymlinkType where
   show FileLink = "FileLink"
   show DirLink = "DirLink"
   show JunctionLink = "JunctionLink"
+  show AutodetectLink = "AutodetectLink"
 
 derive instance eqSymlinkType :: Eq SymlinkType

src/Node/FS/Aff.purs

@@ -156,26 +156,26 @@ toAff5 f a b c d e = toAff (f a b c d e)
 --   -> Aff a
 -- toAff6 f a b c d e t = toAff (f a b c d e t)
 
-access :: String -> Aff (Maybe Error)
+access :: FilePath -> Aff (Maybe Error)
 access path = makeAff \k -> do
   A.access path (k <<< Right)
   pure nonCanceler
 
-access' :: String -> AccessMode -> Aff (Maybe Error)
+access' :: FilePath -> AccessMode -> Aff (Maybe Error)
 access' path mode = makeAff \k -> do
   A.access' path mode (k <<< Right)
   pure nonCanceler
 
-copyFile :: String -> String -> Aff Unit
+copyFile :: FilePath -> FilePath -> Aff Unit
 copyFile = toAff2 A.copyFile
 
-copyFile' :: String -> String -> CopyMode -> Aff Unit
+copyFile' :: FilePath -> FilePath -> CopyMode -> Aff Unit
 copyFile' = toAff3 A.copyFile'
 
-mkdtemp :: String -> Aff String
+mkdtemp :: FilePath -> Aff FilePath
 mkdtemp = toAff1 A.mkdtemp
 
-mkdtemp' :: String -> Encoding -> Aff String
+mkdtemp' :: FilePath -> Encoding -> Aff FilePath
 mkdtemp' = toAff2 A.mkdtemp'
 
 -- |

src/Node/FS/Async.purs

@@ -139,13 +139,13 @@ copyFile' src dest mode cb = runEffectFn4 copyFileImpl src dest mode (handleCall
 
 foreign import copyFileImpl :: EffectFn4 FilePath FilePath CopyMode (JSCallback Unit) Unit
 
-mkdtemp :: String -> Callback String -> Effect Unit
+mkdtemp :: FilePath -> Callback FilePath -> Effect Unit
 mkdtemp prefix = mkdtemp' prefix UTF8
 
-mkdtemp' :: String -> Encoding -> Callback String -> Effect Unit
+mkdtemp' :: FilePath -> Encoding -> Callback FilePath -> Effect Unit
 mkdtemp' prefix encoding cb = runEffectFn3 mkdtempImpl prefix (encodingToNode encoding) (handleCallback cb)
 
-foreign import mkdtempImpl :: EffectFn3 FilePath String (JSCallback String) Unit
+foreign import mkdtempImpl :: EffectFn3 FilePath FilePath (JSCallback FilePath) Unit
 
 foreign import renameImpl :: EffectFn3 FilePath FilePath (JSCallback Unit) Unit
 foreign import truncateImpl :: EffectFn3 FilePath Int (JSCallback Unit) Unit
@@ -154,7 +154,7 @@ foreign import chmodImpl :: EffectFn3 FilePath String (JSCallback Unit) Unit
 foreign import statImpl :: EffectFn2 FilePath (JSCallback Stats) Unit
 foreign import lstatImpl :: EffectFn2 FilePath (JSCallback Stats) Unit
 foreign import linkImpl :: EffectFn3 FilePath FilePath (JSCallback Unit) Unit
-foreign import symlinkImpl :: EffectFn4 FilePath FilePath String (JSCallback Unit) Unit
+foreign import symlinkImpl :: EffectFn4 FilePath FilePath (Nullable String) (JSCallback Unit) Unit
 foreign import readlinkImpl :: EffectFn2 FilePath (JSCallback FilePath) Unit
 foreign import realpathImpl :: forall cache. EffectFn3 FilePath { | cache } (JSCallback FilePath) Unit
 foreign import unlinkImpl :: EffectFn2 FilePath (JSCallback Unit) Unit
@@ -180,7 +180,7 @@ foreign import fstatImpl :: EffectFn2 FileDescriptor (JSCallback Stats) Unit
 foreign import fsyncImpl :: EffectFn2 FileDescriptor (JSCallback Unit) Unit
 foreign import ftruncateImpl :: EffectFn3 FileDescriptor Int (JSCallback Unit) Unit
 foreign import futimesImpl :: EffectFn4 FileDescriptor Int Int (JSCallback Unit) Unit
-foreign import globImpl :: forall filepathOrDirent. EffectFn3 (Array String) { cwd :: Nullable FilePath, exclude :: Nullable (filepathOrDirent -> Boolean), withFileTypes :: Boolean } (JSCallback (Array filepathOrDirent)) Unit
+foreign import globImpl :: forall filepathOrDirent. EffectFn3 (Array FilePath) { cwd :: Nullable FilePath, exclude :: Nullable (filepathOrDirent -> Boolean), withFileTypes :: Boolean } (JSCallback (Array filepathOrDirent)) Unit
 foreign import lchmodImpl :: EffectFn3 FilePath String (JSCallback Unit) Unit
 foreign import lchownImpl :: EffectFn4 FilePath Int Int (JSCallback Unit) Unit
 foreign import lutimesImpl :: EffectFn4 FilePath Int Int (JSCallback Unit) Unit

src/Node/FS/Sync.purs

@@ -93,7 +93,7 @@ foreign import chmodSyncImpl :: EffectFn2 FilePath String Unit
 foreign import statSyncImpl :: EffectFn1 FilePath Stats
 foreign import lstatSyncImpl :: EffectFn1 FilePath Stats
 foreign import linkSyncImpl :: EffectFn2 FilePath FilePath Unit
-foreign import symlinkSyncImpl :: EffectFn3 FilePath FilePath String Unit
+foreign import symlinkSyncImpl :: EffectFn3 FilePath FilePath (Nullable String) Unit
 foreign import readlinkSyncImpl :: EffectFn1 FilePath FilePath
 foreign import realpathSyncImpl :: forall cache. EffectFn2 FilePath { | cache } FilePath
 foreign import unlinkSyncImpl :: EffectFn1 FilePath Unit