Skip to content

Remove FS dependency? #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paf31 opened this issue Jun 7, 2016 · 9 comments
Closed

Remove FS dependency? #2

paf31 opened this issue Jun 7, 2016 · 9 comments

Comments

@paf31
Copy link
Contributor

paf31 commented Jun 7, 2016

It only exists to pull in the FS effect, for requireResolve. Maybe we could just introduce a separate effect for this?

@hdgarrood
Copy link
Member

I think introducing too many distinct effect types would be annoying for application developers, and FS does seem like the right effect for this. If dependencies are becoming a pain perhaps we should reconsider merging all the node APIs into a single package?

@garyb
Copy link
Member

garyb commented Jun 12, 2016

Or a variation on that: we could have all the node effects in a single package, perhaps?

@hdgarrood
Copy link
Member

Yeah, that seems like it could work well.

@hdgarrood
Copy link
Member

What are the others? CHILD_PROCESS, PROCESS, HTTP, READLINE, have I missed any?

@paf31
Copy link
Contributor Author

paf31 commented Jun 12, 2016

Maybe some can be consolidated, like READLINE and CONSOLE or CHILD_PROCESS and PROCESS. I think a SOCKET or NETWORK effect would make sense to unify node-sockets and HTTP too.

@garyb
Copy link
Member

garyb commented Jun 12, 2016

CHILD_PROCESS and PROCESS can't really, the former is when you're spawning and manging other processes, whereas process is for finding out info about the current process. The distinction definitely seems worthwhile to me.

@hdgarrood
Copy link
Member

Yeah, arguably we shouldn't merge READLINE and CONSOLE either, as readline has little to do with consoles specifically, it's for consuming plain text streams one line at a time. A NETWORK effect sounds like a good idea to me though.

@paf31
Copy link
Contributor Author

paf31 commented Jun 12, 2016

I assumed readline was for reading stdin and console for writing to stdout. That's a simplification, but they're both "text i/o" related.

@garyb
Copy link
Member

garyb commented Jun 12, 2016

One for this list: the BUFFER effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants