-
Notifications
You must be signed in to change notification settings - Fork 20
Should argv clone the array? #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, the array itself can change, if you do something like |
I think we should try and fix this for the upcoming 0.14 release for this library. |
Perhaps we can simply set the type of argv as |
Also, should we do the same for |
I think I’d prefer just providing a pair of Effect functions to get and set these values, eg |
The neat think on the ST Global stuff is we can skip having to write custom ffi for freezing arrays and objects (for We can always just hide the functions exposing |
While it makes perfect sense to avoid FFI where possible in most contexts, I don’t think libraries whose purpose is to provide bindings to JS APIs is one of them. I think having custom FFI for these is fine. |
Does this mean the array itself may change? Because if that happens, then
argv
should return a clone of the array to keep users of the array referentially transparent.The text was updated successfully, but these errors were encountered: