diff --git a/CHANGELOG.md b/CHANGELOG.md index f0d3b1e..604a718 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ Breaking changes: New features: Bugfixes: +- `URLSearchParams.getName` does not exist, renamed to the correct name `get` Other improvements: diff --git a/src/Node/URL/URLSearchParams.js b/src/Node/URL/URLSearchParams.js index 55aa984..9fe868b 100644 --- a/src/Node/URL/URLSearchParams.js +++ b/src/Node/URL/URLSearchParams.js @@ -6,7 +6,7 @@ export const fromStringImpl = (str) => new url.URLSearchParams(str); export const fromObjectImpl = (obj) => new url.URLSearchParams(obj); export const appendParamImpl = (name, value, params) => params.append(name, value); export const deleteImpl = (name, params) => params.delete(name); -export const getNameImpl = (name, params) => params.getName(name); +export const getImpl = (name, params) => params.get(name); export const getAllImpl = (name, params) => params.getAll(name); export const hasImpl = (name, params) => params.has(name); export const setImpl = (name, value, params) => params.set(name, value); diff --git a/src/Node/URL/URLSearchParams.purs b/src/Node/URL/URLSearchParams.purs index 4dc7d1f..b340b1a 100644 --- a/src/Node/URL/URLSearchParams.purs +++ b/src/Node/URL/URLSearchParams.purs @@ -5,7 +5,7 @@ module Node.URL.URLSearchParams , fromObject , appendParam , delete - , getName + , get , getAll , has , set @@ -57,10 +57,10 @@ delete name params = runEffectFn2 deleteImpl name params foreign import deleteImpl :: EffectFn2 (String) (URLSearchParams) (Unit) -getName :: String -> URLSearchParams -> Effect (Maybe String) -getName name params = map toMaybe $ runEffectFn2 getNameImpl name params +get :: String -> URLSearchParams -> Effect (Maybe String) +get name params = map toMaybe $ runEffectFn2 getImpl name params -foreign import getNameImpl :: EffectFn2 (String) (URLSearchParams) (Nullable String) +foreign import getImpl :: EffectFn2 (String) (URLSearchParams) (Nullable String) getAll :: String -> URLSearchParams -> Effect (Array String) getAll name params = runEffectFn2 getAllImpl name params diff --git a/test/Main.purs b/test/Main.purs index f66190f..3e3ebdc 100644 --- a/test/Main.purs +++ b/test/Main.purs @@ -2,17 +2,18 @@ module Test.Main where import Prelude -import Effect (Effect) -import Node.URL as URL -import Node.URL.URLSearchParams as URL.Search -import Foreign (unsafeReadTagged) -import Data.Bifunctor (lmap) -import Control.Monad.Except (runExcept) import Control.Monad.Error.Class (liftEither) -import Effect.Exception (error) +import Control.Monad.Except (runExcept) +import Data.Bifunctor (lmap) +import Data.Map as Map +import Data.Maybe (Maybe(..)) import Data.Traversable (for) import Data.Tuple (Tuple(..)) -import Data.Map as Map +import Effect (Effect) +import Effect.Exception (error) +import Foreign (unsafeReadTagged) +import Node.URL as URL +import Node.URL.URLSearchParams as URL.Search import Test.Assert (assertEqual) main ∷ Effect Unit @@ -54,3 +55,11 @@ main = do , Tuple "v" [ "a", "b" ] ] } + + v <- URL.Search.get "v" search + + assertEqual + { actual: v + , expected: Just "a" + } +