refactor wrt will feedback

kn100 · kn100 · commit 3ca47d22fa3c · 2018-08-29T13:31:42.000+01:00
diff --git a/src/main/java/com/pusher/client/connection/websocket/WebSocketConnection.java b/src/main/java/com/pusher/client/connection/websocket/WebSocketConnection.java
@@ -307,10 +307,10 @@ public void run() {
         }, reconnectInterval, TimeUnit.SECONDS);
     }
 
-    // Received error codes 4000 >= 4099 indicate we shouldn't attempt reconnection
+    // Received error codes 4000-4099 indicate we shouldn't attempt reconnection
     // https://pusher.com/docs/pusher_protocol#error-codes
     private boolean shouldReconnect(int code) {
-        return !(code >= 4000 && code <= 4099);
+        return code < 4000 || code >= 4100;
     }
 
     private void cancelTimeoutsAndTransitonToDisconnected() {

Original file line number	Diff line number	Diff line change
`@@ -307,10 +307,10 @@ public void run() {`
`307`	`307`	`}, reconnectInterval, TimeUnit.SECONDS);`
`308`	`308`	`}`
`309`	`309`
`310`		`- // Received error codes 4000 >= 4099 indicate we shouldn't attempt reconnection`
	`310`	`+ // Received error codes 4000-4099 indicate we shouldn't attempt reconnection`
`311`	`311`	`// https://pusher.com/docs/pusher_protocol#error-codes`
`312`	`312`	`private boolean shouldReconnect(int code) {`
`313`		`- return !(code >= 4000 && code <= 4099);`
	`313`	`+ return code < 4000 \|\| code >= 4100;`
`314`	`314`	`}`
`315`	`315`
`316`	`316`	`private void cancelTimeoutsAndTransitonToDisconnected() {`