Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox H2 elements being removed rather than showing ellipsis #25

Open
codemonkeyneo opened this issue Aug 7, 2013 · 0 comments
Open

Comments

@codemonkeyneo
Copy link

Firefox seemed to be the only browser that would remove the content for title elements that were wrapped in H2.

To fix the issue we just altered the offset and then the problem was fixed. Its a quick hack but maybe someone else experiencing the problem can benefit from the work around.

// Iterate until wrapper element height is less than or equal to the original container element
// height plus possible wrapperOffset.
-      while (wrapperElement.innerHeight() > containerElementHeight + wrapperOffset) {
+      while (wrapperElement.innerHeight() > containerElementHeight + (wrapperOffset + 1)) {
        // Apply ellipsis on last text node, by removing one word.
        ellipsisApplied = ellipsisOnLastTextNode(selectedElement);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant