-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Surface temperature" submodel #4022
Comments
Would that be part of the thermal models or a new type of submodel? |
New type of submodel so that it is compatible with any thermal model. |
valentinsulzer
added a commit
that referenced
this issue
Jun 20, 2024
valentinsulzer
added a commit
that referenced
this issue
Jun 20, 2024
valentinsulzer
added a commit
that referenced
this issue
Jun 21, 2024
kratman
added a commit
that referenced
this issue
Aug 27, 2024
* add surface temperature equal to ambient temperature * #4022 surface model works * update temperature comparison script * #4022 update tests and example, rename parameters * fix plot_thermal_components * fix unit tests * #4022 fix lead acid thermal tests * #4022 fix example * coverage * fix test * style * Moving missed files * Rob's suggestion --------- Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: kratman <[email protected]>
@valentinsulzer can the surface temperature model used for other chemistry parameters e.g., Prada2013? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This model accounts for the fact that the surface temperature of a cell in a thermal chamber is typically different from the "set"/"ambient" temperature of the chamber.
Suggested steps to do this below, but open to discussion:
SurfaceAmbientTemperature
which sets surface temperature equal to ambient temperatureSurfaceTemperatureODE
which implements the equation from Mohan et al:BaseBatteryModel
, add an option for "surface temperature" which can be "ambient" (default) or "ODE", then add an if statement for selecting the appropriate modelThe text was updated successfully, but these errors were encountered: