Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Surface temperature" submodel #4022

Closed
valentinsulzer opened this issue Apr 18, 2024 · 3 comments · Fixed by #4203
Closed

Add "Surface temperature" submodel #4022

valentinsulzer opened this issue Apr 18, 2024 · 3 comments · Fixed by #4203

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Apr 18, 2024

This model accounts for the fact that the surface temperature of a cell in a thermal chamber is typically different from the "set"/"ambient" temperature of the chamber.

Suggested steps to do this below, but open to discussion:

  • Add a submodel SurfaceAmbientTemperature which sets surface temperature equal to ambient temperature
  • Add another submodel SurfaceTemperatureODE which implements the equation from Mohan et al:
Screenshot 2024-04-18 at 2 59 00 PM
  • In that submodel, register a citation for that paper
  • In all other thermal submodels, replace "ambient temperature" with "surface temperature"
  • In BaseBatteryModel, add an option for "surface temperature" which can be "ambient" (default) or "ODE", then add an if statement for selecting the appropriate model
  • Add a test for selecting the "ODE" option
  • Add docs
@brosaplanella
Copy link
Member

Would that be part of the thermal models or a new type of submodel?

@valentinsulzer
Copy link
Member Author

New type of submodel so that it is compatible with any thermal model.
One difficulty will be calculating the T_s-T_c/R_c term (surface cooling i.e. ambient heating) for models other than the lumped thermal model. See #4021 (comment)

valentinsulzer added a commit that referenced this issue Jun 20, 2024
valentinsulzer added a commit that referenced this issue Jun 21, 2024
kratman added a commit that referenced this issue Aug 27, 2024
* add surface temperature equal to ambient temperature

* #4022 surface model works

* update temperature comparison script

* #4022 update tests and example, rename parameters

* fix plot_thermal_components

* fix unit tests

* #4022 fix lead acid thermal tests

* #4022 fix example

* coverage

* fix test

* style

* Moving missed files

* Rob's suggestion

---------

Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: kratman <[email protected]>
@wasitahir
Copy link

@valentinsulzer can the surface temperature model used for other chemistry parameters e.g., Prada2013?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants