Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make npt.NDArray type hints more specific #4900

Open
Saransh-cpp opened this issue Mar 8, 2025 · 0 comments · May be fixed by #4901
Open

Make npt.NDArray type hints more specific #4900

Saransh-cpp opened this issue Mar 8, 2025 · 0 comments · May be fixed by #4901
Labels
difficulty: medium Will take a few days priority: low No existing plans to resolve

Comments

@Saransh-cpp
Copy link
Member

Following #4899, we can now make the NDArray type hints more specific by adding dtype of the array. For instance, something like npt.NDArray[np.float64] or npt.NDArray[float].

Ideally, all the npt.NDArray type hints should have an explicit dtype (even if it is Any).
@Saransh-cpp Saransh-cpp added difficulty: medium Will take a few days priority: low No existing plans to resolve labels Mar 8, 2025
@vidipsingh vidipsingh linked a pull request Mar 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium Will take a few days priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make npt.NDArray type hints more specific with dtype vidipsingh/PyBaMM
1 participant
@Saransh-cpp