Skip to content

Commit dc159c3

Browse files
committed
Fix: don’t forward empty JSON bodies on GET (prevents Jira 403)
Non-empty dict → keep existing behavior and send json.dumps(data). Empty dict → remove data from prepared_kwargs so no body is sent. While I understand this is needed I do not understand why the tests ever passed. * Fixes #2362
1 parent b07a89b commit dc159c3

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

jira/resilientsession.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,14 @@ def _jira_prepare(self, **original_kwargs) -> dict:
180180
prepared_kwargs["headers"] = request_headers
181181

182182
data = original_kwargs.get("data", None)
183-
if isinstance(data, dict) and data:
184-
# mypy ensures we don't do this,
185-
# but for people subclassing we should preserve old behaviour
186-
prepared_kwargs["data"] = json.dumps(data)
183+
if isinstance(data, dict):
184+
if data:
185+
# mypy ensures we don't do this,
186+
# but for people subclassing we should preserve old behaviour
187+
prepared_kwargs["data"] = json.dumps(data)
188+
else:
189+
# Don't forward an empty JSON body
190+
prepared_kwargs.pop("data", None)
187191

188192
if "verify" not in prepared_kwargs:
189193
prepared_kwargs["verify"] = self.verify

0 commit comments

Comments
 (0)