Skip to content

Warnings during context.run(): ResourceWarning: unclosed file #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atemate opened this issue Sep 9, 2019 · 2 comments · May be fixed by #928
Open

Warnings during context.run(): ResourceWarning: unclosed file #665

atemate opened this issue Sep 9, 2019 · 2 comments · May be fixed by #928

Comments

@atemate
Copy link

atemate commented Sep 9, 2019 •
edited
Loading

Given configuration:

@task
def test(context):
    context.run('echo 123')

I'm getting ResourceWarnings:

$ inv test
123
sys:1: ResourceWarning: unclosed file <_io.FileIO name=4 mode='wb' closefd=True>
sys:1: ResourceWarning: unclosed file <_io.FileIO name=5 mode='rb' closefd=True>
sys:1: ResourceWarning: unclosed file <_io.FileIO name=7 mode='rb' closefd=True>
$ uname -a
Linux archlinux 5.2.6-arch1-1-ARCH #1 SMP PREEMPT Sun Aug 4 14:58:49 UTC 2019 x86_64 GNU/Linux
$ python --version
Python 3.7.4
$ invoke --version
Invoke 1.3.0
@atemate atemate changed the title Warnings: ResourceWarning: unclosed file Warnings during context.run(): ResourceWarning: unclosed file Sep 9, 2019
@atemate atemate mentioned this issue Sep 9, 2019
Closed
voidus added a commit to voidus/invoke that referenced this issue Mar 25, 2023
@voidus
(Try to) close suprocess file handles after we are done with it
0cea56f 
This should fix pyinvoke#665
@voidus voidus linked a pull request Mar 25, 2023 that will close this issue
Open
@stinovlas
Copy link

Hi! We bumped into this issue. It seems that there is a pull request resolving this issue, but nobody it haven't moved in a while. Is there something we could do to help move things forward?

@allanburleson
Copy link

I'm using Invoke on Windows, and am running into this issue. The tracebacks from tracemalloc show that the unclosed files are always the stdout, stdin, and stderr of a subprocess. My program calls run() regularly, and it eventually crashes from OSError(24, 'Too many open files'). Curious if the aforementioned pull request is all it takes to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Try to) close suprocess file handles after we are done with it voidus/invoke
3 participants
@stinovlas @atemate @allanburleson