Use reverse=True in sort functions instead of sorting and then reversing (#10546)

Note that with this change equal elements occur in reversed order.

Author: vil02

pylint/checkers/symilar.py

@@ -430,8 +430,7 @@ def _compute_sims(self) -> list[tuple[int, set[LinesChunkLimits_T]]]:
             cpls: set[LinesChunkLimits_T]
             for cpls in ensembles:
                 sims.append((num, cpls))
-        sims.sort()
-        sims.reverse()
+        sims.sort(reverse=True)
         return sims
 
     def _display_sims(

pylint/lint/report_functions.py

@@ -30,14 +30,15 @@ def report_messages_stats(
 ) -> None:
     """Make messages type report."""
     by_msg_stats = stats.by_msg
-    in_order = sorted(
-        (value, msg_id)
-        for msg_id, value in by_msg_stats.items()
-        if not msg_id.startswith("I")
-    )
-    in_order.reverse()
     lines = ["message id", "occurrences"]
-    for value, msg_id in in_order:
+    for value, msg_id in sorted(
+        (
+            (value, msg_id)
+            for msg_id, value in by_msg_stats.items()
+            if not msg_id.startswith("I")
+        ),
+        reverse=True,
+    ):
         lines += [msg_id, str(value)]
     sect.append(Table(children=lines, cols=2, rheaders=1))
 
@@ -70,8 +71,7 @@ def report_messages_by_module_stats(
                 module,
             )
         )
-    sorted_result.sort()
-    sorted_result.reverse()
+    sorted_result.sort(reverse=True)
     lines = ["module", "error", "warning", "refactor", "convention"]
     for line in sorted_result:
         # Don't report clean modules.

tests/checkers/unittest_symilar.py

@@ -67,6 +67,15 @@ def test_ignore_docstrings() -> None:
         == (
             f"""
 5 similar lines in 2 files
+=={SIMILAR1}:[0:5]
+=={SIMILAR2}:[0:5]
+   import one
+   from two import two
+   three
+   four
+   five
+
+5 similar lines in 2 files
 =={SIMILAR1}:[7:15]
 =={SIMILAR2}:[7:15]
    seven
@@ -77,15 +86,6 @@ def test_ignore_docstrings() -> None:
    twelve '''
    thirteen
    fourteen
-
-5 similar lines in 2 files
-=={SIMILAR1}:[0:5]
-=={SIMILAR2}:[0:5]
-   import one
-   from two import two
-   three
-   four
-   five
 TOTAL lines=62 duplicates=10 percent=16.13
 """
         ).strip()