Misc cleanup (#10580)

Author: cdce8p

doc/whatsnew/fragments/10559.new_check

@@ -1,6 +1,6 @@
-Add new checks for invalid uses of class patterns in ``match``.
-* ``invalid-match-args-definition`` is emitted if ``__match_args__`` isn't a tuple of strings.
-* ``too-many-positional-sub-patterns`` if there are more positional sub-patterns than specified in ``__match_args__``.
-* ``multiple-class-sub-patterns`` if there are multiple sub-patterns for the same attribute.
+Add new checks for invalid uses of class patterns in :keyword:`match`.
+* :ref:`invalid-match-args-definition` is emitted if :py:data:`object.__match_args__` isn't a tuple of strings.
+* :ref:`too-many-positional-sub-patterns` if there are more positional sub-patterns than specified in :py:data:`object.__match_args__`.
+* :ref:`multiple-class-sub-patterns` if there are multiple sub-patterns for the same attribute.
 
 Refs #10559

pylint/checkers/base/basic_checker.py

@@ -717,7 +717,7 @@ def visit_assert(self, node: nodes.Assert) -> None:
         match node.test:
             case nodes.Tuple(elts=elts) if len(elts) > 0:
                 self.add_message("assert-on-tuple", node=node, confidence=HIGH)
-            case nodes.Const(value=str(val)):
+            case nodes.Const(value=str() as val):
                 when = "never" if val else "always"
                 self.add_message("assert-on-string-literal", node=node, args=(when,))
 

pylint/checkers/base/comparison_checker.py

@@ -146,7 +146,7 @@ def _check_nan_comparison(
         def _is_float_nan(node: nodes.NodeNG) -> bool:
             try:
                 match node:
-                    case nodes.Call(args=[nodes.Const(value=str(value))]) if (
+                    case nodes.Call(args=[nodes.Const(value=str() as value)]) if (
                         value.lower() == "nan"
                     ):
                         return node.inferred()[0].pytype() == "builtins.float"  # type: ignore[no-any-return]

pylint/checkers/base/name_checker/checker.py

@@ -17,6 +17,7 @@
 from typing import TYPE_CHECKING
 
 import astroid
+import astroid.bases
 from astroid import nodes
 from astroid.typing import InferenceResult
 

pylint/checkers/classes/class_checker.py

@@ -14,6 +14,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple, TypeAlias
 
 import astroid
+import astroid.objects
 from astroid import bases, nodes, util
 from astroid.nodes import LocalsDictNodeNG
 from astroid.typing import SuccessfulInferenceResult
@@ -1641,7 +1642,7 @@ def _check_slots_elt(
             match inferred:
                 case util.UninferableBase():
                     continue
-                case nodes.Const(value=str(value)) if value:
+                case nodes.Const(value=str() as value) if value:
                     pass
                 case _:
                     self.add_message(

pylint/checkers/refactoring/refactoring_checker.py

@@ -14,6 +14,7 @@
 from typing import TYPE_CHECKING, Any, NamedTuple, TypeAlias, cast
 
 import astroid
+import astroid.objects
 from astroid import bases, nodes
 from astroid.util import UninferableBase
 
@@ -1125,7 +1126,6 @@ def _check_consider_using_generator(self, node: nodes.Call) -> None:
             inside_comp = f"({inside_comp})"
             inside_comp += ", "
             inside_comp += ", ".join(kw.as_string() for kw in node.keywords)
-        call_name = node.func.name
         if call_name in {"any", "all"}:
             self.add_message(
                 "use-a-generator",
@@ -2043,7 +2043,7 @@ def _is_node_return_ended(self, node: nodes.NodeNG) -> bool:
                 return any(
                     self._is_node_return_ended(_child) for _child in all_but_handler
                 ) and all(self._is_node_return_ended(_child) for _child in handlers)
-            case nodes.Assert(test=nodes.Const(value=value)) if not value:
+            case nodes.Assert(test=nodes.Const(value=False | 0)):
                 # consider assert False as a return node
                 return True
         # recurses on the children of the node

pylint/checkers/typecheck.py

@@ -1755,10 +1755,9 @@ def _check_invalid_sequence_index(self, subscript: nodes.Subscript) -> None:
         if index_type is None or isinstance(index_type, util.UninferableBase):
             return None
         match index_type:
-            case nodes.Const():
+            case nodes.Const(value=int()):
                 # Constants must be of type int
-                if isinstance(index_type.value, int):
-                    return None
+                return None
             case astroid.Instance():
                 # Instance values must be int, slice, or have an __index__ method
                 if index_type.pytype() in {"builtins.int", "builtins.slice"}:

pylint/checkers/utils.py

@@ -1704,8 +1704,7 @@ def is_test_condition(
     parent: nodes.NodeNG | None = None,
 ) -> bool:
     """Returns true if the given node is being tested for truthiness."""
-    parent = parent or node.parent
-    match parent:
+    match parent := parent or node.parent:
         case nodes.While() | nodes.If() | nodes.IfExp() | nodes.Assert():
             return node is parent.test or parent.test.parent_of(node)
         case nodes.Comprehension():

pylint/checkers/variables.py

@@ -1038,7 +1038,7 @@ def _check_loop_finishes_via_except(
         """
         if not other_node_try_except.orelse:
             return False
-        closest_loop: None | (nodes.For | nodes.While) = (
+        closest_loop: nodes.For | nodes.While | None = (
             utils.get_node_first_ancestor_of_type(node, (nodes.For, nodes.While))
         )
         if closest_loop is None:
@@ -3034,7 +3034,7 @@ def _store_type_annotation_node(self, type_annotation: nodes.NodeNG) -> None:
                 return
 
         match type_annotation.value:
-            case nodes.Attribute(expr=nodes.Name(name=n)) if n == TYPING_MODULE:
+            case nodes.Attribute(expr=nodes.Name(name=name)) if name == TYPING_MODULE:
                 self._type_annotation_names.append(TYPING_MODULE)
                 return
 

pylint/extensions/_check_docs_utils.py

@@ -41,9 +41,7 @@ def get_setters_property_name(node: nodes.FunctionDef) -> str | None:
     decorators = node.decorators.nodes if node.decorators else []
     for decorator in decorators:
         match decorator:
-            case nodes.Attribute(attrname=attrname, expr=nodes.Name(name=name)) if (
-                attrname == "setter"
-            ):
+            case nodes.Attribute(attrname="setter", expr=nodes.Name(name=name)):
                 return name  # type: ignore[no-any-return]
     return None