Commit e2e7491
committed
Unpin pre-commit version in tox
The config uses the `pre-commit/pre-commit-hook` repository which
since v5.0 has multiple hooks using the `pre-commit` stage which was
only added in pre-commit [3.2.0][] causing a run failure when run
under a pre-commit pinned to 2.2. From a very surface looks it seems
like https://pre-commit.ci/ is anal about keeping everything on latest
so pinning pre-commit in tox seems like it can only cause problems (by
drifting behind the actual CI).
Of note: it looks like the `minimum_pre_commit_version` stricture on
hooks does not do anything: all the `pre-commit` hooks are filtered on
version except [`destroyed-symlinks`][] but I get an error on
`check-added-large-file`:
==> At Hook(id='check-added-large-files')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
[3.2.0]: https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md#320---2023-03-17
[`destroyed-symlinks`]: pre-commit/pre-commit-hooks@c7d1e851 parent 7588243 commit e2e7491
2 files changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
139 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
140 | 147 | | |
141 | 148 | | |
142 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
0 commit comments