fix(expand_modules): pass ignore_list to modutils.get_module_files

[shifqu]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #10669

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (eade69e) to head (f75ffd0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10720   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         176      176           
  Lines       19540    19540           
=======================================
  Hits        18755    18755           
  Misses        785      785           

Files with missing lines	Coverage Δ
pylint/lint/expand_modules.py	95.34% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Pierre-Sassoulas]

Thank you great PR, and great catch.

[shifqu]

@Pierre-Sassoulas , what is keeping us from merging this? If there is any more work to be done, I'd like to get it done :)

The linked issue is labeled 'high priority' and this PR effectively restores functionality.

[Pierre-Sassoulas]

Yeah sorry I wanted to release this asap but I need to reproduce the bug and test the fix which I wasn't able to. Adding an automated test, if at all possible, would help.

[shifqu]

Thanks for letting me know, I attempted to write a test for it, I used the repro steps from the linked issue, added this under regrtest_data and then point to that in the test_expand_modules.py test-file. The test passes, but if you revert my change, the test fails, because it would return the test/init.py file as well.

The ignore_list_re = [re.compile("^\\.#")] comes from my local repo where I can reproduce the issue. This is what it passed to expand_modules.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit f75ffd0

[Pierre-Sassoulas]

Great, thank you !

[Pierre-Sassoulas]

Congratulation on becoming a pylint contributor, on a very impactful issue too 🎉