Skip to content

A minor bug when checking display_errors in installCheck.php? #6

@janpjens

Description

@janpjens

In installCheck.php the ini_get function is called to check if display_errors is disabled, comparing it to 0 or off. However, the ini_get function may also return an empty string when booleans are 0.
This was the case on my installation (display_errors = Off in php.ini, debian, php 5.4).

From http://php.net/manual/en/function.ini-get.php:

A boolean ini value of off will be returned as an empty string or "0" while a boolean ini value of on will be returned as "1". The function can also return the literal string of INI value.

A check involving empty() or similar could be proposed, but since the author seems strict (probably for a good reason!) with these checks I will leave the decision to him.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions