Skip to content

Commit 334362f

Browse files
committed
Remove more traces of setup.py install
1 parent 57c9ca3 commit 334362f

File tree

3 files changed

+1
-13
lines changed

3 files changed

+1
-13
lines changed

docs/html/reference/build-system/setup-py.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ The overall process for building a package is:
2424

2525
- Generate the package's metadata.
2626
- Generate a wheel for the package.
27-
- If this fails and we're trying to install the package, attempt a direct
28-
installation.
2927

3028
The wheel can then be used to perform an installation, if necessary.
3129

@@ -58,13 +56,6 @@ If this wheel generation fails, pip runs `setup.py clean` to clean up any build
5856
artifacts that may have been generated. After that, pip will attempt a direct
5957
installation.
6058

61-
### Direct Installation
62-
63-
When all else fails, pip will invoke `setup.py install` to install a package
64-
using setuptools' mechanisms to perform the installation. This is currently the
65-
last-resort fallback for projects that cannot be built into wheels, and may not
66-
be supported in the future.
67-
6859
### Editable Installation
6960

7061
For installing packages in "editable" mode

tests/functional/test_install.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1160,7 +1160,6 @@ def test_install_package_with_prefix(
11601160
rel_prefix_path = script.scratch / "prefix"
11611161
install_path = join(
11621162
sysconfig.get_path("purelib", vars={"base": rel_prefix_path}),
1163-
# we still test for egg-info because no-binary implies setup.py install
11641163
"simple-1.0.dist-info",
11651164
)
11661165
result.did_create(install_path)
@@ -1606,7 +1605,6 @@ def test_install_no_binary_builds_pep_517_wheel(
16061605
assert expected in str(res), str(res)
16071606

16081607
assert "Building wheel for pep517-setup" in str(res), str(res)
1609-
assert "Running setup.py install for pep517-set" not in str(res), str(res)
16101608

16111609

16121610
@pytest.mark.network

tests/functional/test_install_reqs.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,6 @@ def test_wheel_user_with_prefix_in_pydistutils_cfg(
325325
"install", "--user", "--no-index", "-f", data.find_links, "requiresupper"
326326
)
327327
# Check that we are really installing a wheel
328-
assert "Running setup.py install for requiresupper" not in result.stdout
329328
assert "installed requiresupper" in result.stdout
330329

331330

@@ -647,7 +646,7 @@ def test_install_distribution_union_with_constraints(
647646
msg = "Unnamed requirements are not allowed as constraints"
648647
assert msg in result.stderr
649648
else:
650-
assert "Running setup.py install for LocalExtras" in result.stdout
649+
assert "Building wheel for LocalExtras" in result.stdout
651650
result.did_create(script.site_packages / "singlemodule.py")
652651

653652

0 commit comments

Comments
 (0)