Merge pull request #7275 from chrahunt/refactor/return-installedrequirement

Return InstallationResult from requirement installation

Author: chrahunt

src/pip/_internal/commands/install.py

@@ -463,13 +463,13 @@ def run(self, options, args):
                 )
                 working_set = pkg_resources.WorkingSet(lib_locations)
 
-                reqs = sorted(installed, key=operator.attrgetter('name'))
+                installed.sort(key=operator.attrgetter('name'))
                 items = []
-                for req in reqs:
-                    item = req.name
+                for result in installed:
+                    item = result.name
                     try:
                         installed_version = get_installed_version(
-                            req.name, working_set=working_set
+                            result.name, working_set=working_set
                         )
                         if installed_version:
                             item += '-' + installed_version

src/pip/_internal/req/__init__.py

@@ -23,14 +23,24 @@
 logger = logging.getLogger(__name__)
 
 
+class InstallationResult(object):
+    def __init__(self, name):
+        # type: (str) -> None
+        self.name = name
+
+    def __repr__(self):
+        # type: () -> str
+        return "InstallationResult(name={!r})".format(self.name)
+
+
 def install_given_reqs(
     to_install,  # type: List[InstallRequirement]
     install_options,  # type: List[str]
     global_options=(),  # type: Sequence[str]
     *args,  # type: Any
     **kwargs  # type: Any
 ):
-    # type: (...) -> List[InstallRequirement]
+    # type: (...) -> List[InstallationResult]
     """
     Install everything in the given list.
 
@@ -43,6 +53,8 @@ def install_given_reqs(
             ', '.join([req.name for req in to_install]),
         )
 
+    installed = []
+
     with indent_log():
         for requirement in to_install:
             if requirement.conflicts_with:
@@ -79,4 +91,6 @@ def install_given_reqs(
                     uninstalled_pathset.commit()
             requirement.remove_temporary_source()
 
-    return to_install
+            installed.append(InstallationResult(requirement.name))
+
+    return installed