Skip to content

Consistently pass verbosity flag to VCS (git) module #13329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
ByteB4rb1e opened this issue Apr 9, 2025 · 4 comments
Open
1 task done

Consistently pass verbosity flag to VCS (git) module #13329

ByteB4rb1e opened this issue Apr 9, 2025 · 4 comments
Labels
state: awaiting PR Feature discussed, PR is needed type: feature request Request for a new feature

Comments

@ByteB4rb1e
Copy link

What's the problem this feature will solve?

Providing the --verbose argument to pip when installing a package via git+https does not result in the verbosity being passed down to the VCS (Git) subshell commands, e.g. git submodule update.

I am on a slow and unstable internet connection. When installing packages via git+https with lots of submodules I'd like to stay informed on the progress, as to ensure that I still have a connection to the Git repository hosts referenced by the submodules and can identify when Git has detected a broken connection and is retrying.

Describe the solution you'd like

There does not seem to be an environment variable for configuring Git verbosity globally, so passing it to the VersionControl::unset_environ base class does not seem to be an option.

Instead it might be feasible to (either/or):

  • Refactor the VersionControl interface to allow for explicitly passing additional subshell arguments
  • Refactor the VersionControl interface specifically for passing a generic verbosity flag

In both instances the subshell command(s) affected by this feature request would need to be adapted to accept the verbosity flag.

Alternative Solutions

As described in solution

Additional context

n/a

Code of Conduct

@ByteB4rb1e ByteB4rb1e added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Apr 9, 2025
@notatallshaw
Copy link
Member

Do you imagine this would be when you run pip with -v or are you proposing a new VCS verbose flag?

@ByteB4rb1e
Copy link
Author

When running with the default -v flag, so basically a cascade, (carefully) applying the verbosity to subsystems as well.

@notatallshaw notatallshaw added state: awaiting PR Feature discussed, PR is needed and removed S: needs triage Issues/PRs that need to be triaged labels Apr 11, 2025
@notatallshaw
Copy link
Member

notatallshaw commented Apr 11, 2025

That seems reasonable to me, I'll mark this is awaiting a PR (pip is a volunteer project, so someone would need to choose to take up the work).

@uranusjr
Copy link
Member

We already pass verbosity to git sometimes, but not consistently. Feel free to submit a fix.

self, dest: str, url: HiddenText, rev_options: RevOptions, verbosity: int

@uranusjr uranusjr changed the title Pass verbosity flag to VCS (git) module Consistently pass verbosity flag to VCS (git) module Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: awaiting PR Feature discussed, PR is needed type: feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants