Fixed invalid regex handling in filterwarnings #13124

virendrapatil24 · 2025-01-11T12:00:29Z

Updated the parse_warning_filter method to handle invalid regex pattern provided to message/module args.
Added a test case in testing/test_warnings.py to validate the new behavior.
Created a changelog fragment to document this improvement.

for more information, see https://pre-commit.ci

The-Compiler

Nice! Definitely much better. New output (with my small suggestion added):

ERROR: while parsing the following warning configuration:

  ignore::DeprecationWarning:*

This error occurred:

Invalid regex '*': nothing to repeat at position 0

src/_pytest/config/__init__.py

…com/virendrapatil24/pytest into fix-invalid-regex-in-filterwarnings

for more information, see https://pre-commit.ci

nicoddemus

LGTM, thanks!

testing/test_warnings.py

graingert · 2025-01-21T10:09:47Z

testing/test_warnings.py

+        result = pytester.runpytest_subprocess()
+        result.stderr.fnmatch_lines(
+            [
+                "*Invalid regex '*': nothing to repeat at position 0*",


I think it would be more thorough to test on the whole "while parsing ..." output?

graingert · 2025-01-21T10:13:51Z

it looks like there's no tests for "invalid lineno (negative AND not an integer)", too many fields, invalid action or resolving the warning category

perhaps you'd be interested in adding these tests? Should be very similar to test_invalid_regex_in_filterwarning perhaps in this PR or perhaps in a followup?

virendrapatil24 · 2025-01-28T16:00:45Z

Thanks for the review!

I’m a bit confused about what else is required for this PR. Could you summarize the key changes you’d like to see here? From my understanding, the missing tests you mentioned might be better suited for a follow-up rather than this ticket. Let me know your thoughts!

graingert · 2025-01-28T16:44:34Z

Thanks for the review!

I’m a bit confused about what else is required for this PR. Could you summarize the key changes you’d like to see here? From my understanding, the missing tests you mentioned might be better suited for a follow-up rather than this ticket. Let me know your thoughts!

So yeah could you:

Assert on the exit code of pytester
Assert on the full output starting with "while parsing the following warning configuration: ..." in the stderr.fnmatch_lines assertion

virendrapatil24 · 2025-01-29T08:40:02Z

Thanks for the review!
I’m a bit confused about what else is required for this PR. Could you summarize the key changes you’d like to see here? From my understanding, the missing tests you mentioned might be better suited for a follow-up rather than this ticket. Let me know your thoughts!

So yeah could you:

Assert on the exit code of pytester

Assert on the full output starting with "while parsing the following warning configuration: ..." in the stderr.fnmatch_lines assertion

sure will make those asserts, thanks for clarifying.

graingert · 2025-01-29T10:18:26Z

testing/test_warnings.py

+                "",
+                "This error occurred:",
+                "",
+                "Invalid regex '*': nothing to repeat at position 0",


I think you need to escape this star or it will treat it as a wildcard/fnmatch syntax. I'm not sure how to escape it though

Suggested change

"Invalid regex '*': nothing to repeat at position 0",

r"Invalid regex '\*': nothing to repeat at position 0",

makes sense, I will check what I can do here.

we can escape * using [*]
ref: https://docs.python.org/3/library/fnmatch.html

testing/test_warnings.py

virendrapatil24 and others added 3 commits January 11, 2025 16:40

handles invalid regex for filterwarnings

ca22e6f

adds testcase for invalid regex

2688436

[pre-commit.ci] auto fixes from pre-commit.com hooks

42b50b4

for more information, see https://pre-commit.ci

The-Compiler requested changes Jan 11, 2025

View reviewed changes

src/_pytest/config/__init__.py Outdated Show resolved Hide resolved

virendrapatil24 added 2 commits January 11, 2025 17:41

adds changelog

0f6868d

Merge branch 'fix-invalid-regex-in-filterwarnings' of https://github.…

745083d

…com/virendrapatil24/pytest into fix-invalid-regex-in-filterwarnings

psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jan 11, 2025

pre-commit-ci bot and others added 5 commits January 11, 2025 12:14

[pre-commit.ci] auto fixes from pre-commit.com hooks

e915437

for more information, see https://pre-commit.ci

updates error syntax

3cddb3c

[pre-commit.ci] auto fixes from pre-commit.com hooks

ba62c29

for more information, see https://pre-commit.ci

updates changelog desc

3119e02

[pre-commit.ci] auto fixes from pre-commit.com hooks

913d388

for more information, see https://pre-commit.ci

virendrapatil24 marked this pull request as ready for review January 11, 2025 14:45

error fix

d5d8608

virendrapatil24 requested a review from The-Compiler January 11, 2025 15:31

nicoddemus approved these changes Jan 12, 2025

View reviewed changes

graingert reviewed Jan 21, 2025

View reviewed changes

testing/test_warnings.py Show resolved Hide resolved

graingert reviewed Jan 21, 2025

View reviewed changes

testing/test_warnings.py Outdated Show resolved Hide resolved

graingert reviewed Jan 21, 2025

View reviewed changes

graingert approved these changes Jan 21, 2025

View reviewed changes

Update testing/test_warnings.py

355b802

updates test case

6b9ee36

graingert reviewed Jan 29, 2025

View reviewed changes

graingert approved these changes Jan 29, 2025

View reviewed changes

updates testcase

0a88aba

graingert reviewed Jan 29, 2025

View reviewed changes

testing/test_warnings.py Outdated Show resolved Hide resolved

Update testing/test_warnings.py

1581a63

graingert approved these changes Jan 29, 2025

View reviewed changes

Merge branch 'main' into fix-invalid-regex-in-filterwarnings

49f0dff

graingert enabled auto-merge (squash) January 29, 2025 10:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed invalid regex handling in filterwarnings #13124

Fixed invalid regex handling in filterwarnings #13124

virendrapatil24 commented Jan 11, 2025 •

edited

Loading

The-Compiler left a comment

nicoddemus left a comment

graingert Jan 21, 2025

graingert commented Jan 21, 2025 •

edited

Loading

virendrapatil24 commented Jan 28, 2025

graingert commented Jan 28, 2025 •

edited

Loading

virendrapatil24 commented Jan 29, 2025

graingert Jan 29, 2025

virendrapatil24 Jan 29, 2025

virendrapatil24 Jan 29, 2025

	"Invalid regex '*': nothing to repeat at position 0",
	r"Invalid regex '\*': nothing to repeat at position 0",

Fixed invalid regex handling in filterwarnings #13124

Are you sure you want to change the base?

Fixed invalid regex handling in filterwarnings #13124

Conversation

virendrapatil24 commented Jan 11, 2025 • edited Loading

The-Compiler left a comment

Choose a reason for hiding this comment

nicoddemus left a comment

Choose a reason for hiding this comment

graingert Jan 21, 2025

Choose a reason for hiding this comment

graingert commented Jan 21, 2025 • edited Loading

virendrapatil24 commented Jan 28, 2025

graingert commented Jan 28, 2025 • edited Loading

virendrapatil24 commented Jan 29, 2025

graingert Jan 29, 2025

Choose a reason for hiding this comment

virendrapatil24 Jan 29, 2025

Choose a reason for hiding this comment

virendrapatil24 Jan 29, 2025

Choose a reason for hiding this comment

virendrapatil24 commented Jan 11, 2025 •

edited

Loading

graingert commented Jan 21, 2025 •

edited

Loading

graingert commented Jan 28, 2025 •

edited

Loading