feat(lazer) Convert market Session to enum

Author: aditya520

lazer/contracts/evm/script/fetch_pyth_payload.sh

@@ -12,7 +12,7 @@ response_feed3=$(curl -X GET "$API_URL" \
   --header "Content-Type: application/json" \
   --data-raw '{
     "priceFeedIds": [3],
-    "properties": ["price", "bestBidPrice", "bestAskPrice", "publisherCount", "exponent", "confidence"],
+    "properties": ["price", "bestBidPrice", "bestAskPrice", "publisherCount", "exponent", "confidence", "marketSession"],
     "chains": ["evm"],
     "channel": "fixed_rate@200ms",
     "deliveryFormat": "json",

lazer/contracts/evm/src/PythLazerLib.sol

@@ -412,10 +412,18 @@ library PythLazerLib {
                 } else if (
                     property == PythLazerStructs.PriceFeedProperty.MarketSession
                 ) {
-                    (feed._marketSession, pos) = parseFeedValueInt16(
+                    int16 marketSessionValue;
+                    (marketSessionValue, pos) = parseFeedValueInt16(
                         payload,
                         pos
                     );
+                    require(
+                        marketSessionValue >= 0 && marketSessionValue <= 4,
+                        "Invalid market session value"
+                    );
+                    feed._marketSession = PythLazerStructs.MarketSession(
+                        uint8(uint16(marketSessionValue))
+                    );
                     _setPresent(
                         feed,
                         uint8(PythLazerStructs.PriceFeedProperty.MarketSession)
@@ -771,7 +779,7 @@ library PythLazerLib {
     /// @notice Get market session (reverts if not exists)
     function getMarketSession(
         PythLazerStructs.Feed memory feed
-    ) public pure returns (int16) {
+    ) public pure returns (PythLazerStructs.MarketSession) {
         require(
             isMarketSessionRequested(feed),
             "Market session is not requested for the timestamp"

lazer/contracts/evm/src/PythLazerStructs.sol

@@ -33,6 +33,14 @@ library PythLazerStructs {
         Present
     }
 
+    enum MarketSession {
+        Regular,
+        PreMarket,
+        PostMarket,
+        OverNight,
+        Closed
+    }
+
     struct Feed {
         // NOTE: Do not access fields directly. Use PythLazerLib getters (getPrice, hasPrice, isPriceRequested, etc.)
 
@@ -53,8 +61,8 @@ library PythLazerStructs {
         int64 _fundingRate;
         uint64 _fundingTimestamp;
         uint64 _fundingRateInterval;
-        // Slot 4: 2 bytes
-        int16 _marketSession;
+        // Slot 4: 1 byte
+        MarketSession _marketSession;
     }
 
     struct Update {

lazer/contracts/evm/test/PythLazer.t.sol

@@ -219,7 +219,10 @@ contract PythLazerTest is Test {
         assertEq(feed._fundingRate, 123456);
         assertEq(feed._fundingTimestamp, 1234567890);
         assertEq(feed._fundingRateInterval, 3600);
-        assertEq(feed._marketSession, 0);
+        assertEq(
+            uint8(feed._marketSession),
+            uint8(PythLazerStructs.MarketSession.Regular)
+        );
 
         // Verify exists flags (all should be set)
         assertTrue(PythLazerLib.hasPrice(feed));
@@ -395,10 +398,16 @@ contract PythLazerTest is Test {
 
         PythLazerStructs.Feed memory feed = update.feeds[0];
 
-        assertEq(feed._marketSession, 1);
+        assertEq(
+            uint8(feed._marketSession),
+            uint8(PythLazerStructs.MarketSession.PreMarket)
+        );
         assertTrue(PythLazerLib.hasMarketSession(feed));
         assertTrue(PythLazerLib.isMarketSessionRequested(feed));
-        assertEq(PythLazerLib.getMarketSession(feed), 1);
+        assertEq(
+            uint8(PythLazerLib.getMarketSession(feed)),
+            uint8(PythLazerStructs.MarketSession.PreMarket)
+        );
 
         // Test different market session values
         bytes[] memory properties2 = new bytes[](3);
@@ -419,8 +428,14 @@ contract PythLazerTest is Test {
             .parseUpdateFromPayload(payload2);
 
         PythLazerStructs.Feed memory feed2 = update2.feeds[0];
-        assertEq(feed2._marketSession, 2);
-        assertEq(PythLazerLib.getMarketSession(feed2), 2);
+        assertEq(
+            uint8(feed2._marketSession),
+            uint8(PythLazerStructs.MarketSession.PostMarket)
+        );
+        assertEq(
+            uint8(PythLazerLib.getMarketSession(feed2)),
+            uint8(PythLazerStructs.MarketSession.PostMarket)
+        );
     }
 
     /// @notice Test MarketSession getter when not requested

lazer/contracts/evm/test/PythLazerApi.t.sol

@@ -156,10 +156,19 @@ contract PythLazerApiTest is Test {
                 PythLazerLib.hasMarketSession(feed3),
                 "Feed 3: if market session is requested, it should be present"
             );
-            int16 marketSession = PythLazerLib.getMarketSession(feed3);
-            // MarketSession should be a valid value (0-4 based on enum)
-            assertGe(marketSession, 0, "Feed 3: market session should be >= 0");
-            assertLe(marketSession, 4, "Feed 3: market session should be <= 4");
+            PythLazerStructs.MarketSession marketSession = PythLazerLib
+                .getMarketSession(feed3);
+            // MarketSession should be a valid enum value (0-4)
+            assertGe(
+                uint8(marketSession),
+                0,
+                "Feed 3: market session should be >= 0"
+            );
+            assertLe(
+                uint8(marketSession),
+                4,
+                "Feed 3: market session should be <= 4"
+            );
         }
 
         // Verify parsed values match API reference values exactly
@@ -318,15 +327,16 @@ contract PythLazerApiTest is Test {
                 PythLazerLib.hasMarketSession(feed112),
                 "Feed 112: if market session is requested, it should be present"
             );
-            int16 marketSession = PythLazerLib.getMarketSession(feed112);
-            // MarketSession should be a valid value (0-4 based on enum)
+            PythLazerStructs.MarketSession marketSession = PythLazerLib
+                .getMarketSession(feed112);
+            // MarketSession should be a valid enum value (0-4)
             assertGe(
-                marketSession,
+                uint8(marketSession),
                 0,
                 "Feed 112: market session should be >= 0"
             );
             assertLe(
-                marketSession,
+                uint8(marketSession),
                 4,
                 "Feed 112: market session should be <= 4"
             );