Skip to content

Commit b8bc7b5

Browse files
committed
Merge remote-tracking branch 'origin/sphinx-attr-getter-ext' into sphinx-attr-getter-ext
2 parents 6dd385b + 202c218 commit b8bc7b5

1 file changed

Lines changed: 9 additions & 12 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,26 +14,23 @@ If an item doesn't apply to your pull request, **check it anyway** to make it ap
1414
If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.
1515
-->
1616

17-
- [ ] Do **not** open pull requests from your `main` branch – [**use a separate branch**](https://hynek.me/articles/pull-requests-branch/)!
18-
- There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
19-
- This is not a pre-requisite for your pull request to be accepted, but **you have been warned**.
20-
- [ ] Added **tests** for changed code.
21-
Our CI fails if coverage is not 100%.
17+
- [ ] I acknowledge this project's [**AI policy**](https://github.com/python-attrs/attrs/blob/main/.github/AI_POLICY.md).
18+
- [ ] This pull requests is [**not** from my `main` branch](https://hynek.me/articles/pull-requests-branch/).
19+
- Consider granting [push permissions to the PR branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork), so maintainers can fix minor issues themselves without pestering you.
20+
- [ ] There's **tests** for all new and changed code.
2221
- [ ] Changes or additions to public APIs are reflected in our type stubs (files ending in ``.pyi``).
2322
- [ ] ...and used in the stub test file `typing-examples/baseline.py` or, if necessary, `typing-examples/mypy.py`.
2423
- [ ] If they've been added to `attr/__init__.pyi`, they've *also* been re-imported in `attrs/__init__.pyi`.
25-
- [ ] Updated **documentation** for changed code.
24+
- [ ] The **documentation** has been updated.
2625
- [ ] New functions/classes have to be added to `docs/api.rst` by hand.
2726
- [ ] Changes to the signatures of `@attr.s()` and `@attrs.define()` have to be added by hand too.
2827
- [ ] Changed/added classes/methods/functions have appropriate `versionadded`, `versionchanged`, or `deprecated` [directives](http://www.sphinx-doc.org/en/stable/markup/para.html#directive-versionadded).
2928
The next version is the second number in the current release + 1.
3029
The first number represents the current year.
31-
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
32-
If the next version is the first in the new year, it'll be 23.1.0.
33-
- [ ] If something changed that affects both `attrs.define()` and `attr.s()`, you have to add version directives to both.
34-
- [ ] Documentation in `.rst` and `.md` files is written using [semantic newlines](https://rhodesmill.org/brandon/2012/one-sentence-per-line/).
35-
- [ ] Changes (and possible deprecations) have news fragments in [`changelog.d`](https://github.com/python-attrs/attrs/blob/main/changelog.d).
36-
- [ ] Consider granting [push permissions to the PR branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork), so maintainers can fix minor issues themselves without pestering you.
30+
So if the current version on PyPI is 26.2.0, the next version is gonna be 26.3.0.
31+
If the next version is the first in the new year, it'll be 27.1.0.
32+
- [ ] Documentation in `.rst` and `.md` files is written using [semantic newlines](https://rhodesmill.org/brandon/2012/one-sentence-per-line/).
33+
- [ ] Changes have news fragments in [`changelog.d`](https://github.com/python-attrs/attrs/blob/main/changelog.d).
3734

3835
<!--
3936
If you have *any* questions to *any* of the points above, just **submit and ask**!

0 commit comments

Comments
 (0)