Skip to content

Commit 8fee45d

Browse files
committed
replace time.sleep() with smarter WebDriverWait() in Map._to_png
1 parent 7bf5fbe commit 8fee45d

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

folium/folium.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,11 +392,16 @@ def _to_png(
392392
*size,
393393
)
394394
driver.set_window_size(*window_size)
395+
from selenium.webdriver.support.ui import WebDriverWait
396+
395397
html = self.get_root().render()
396398
with temp_html_filepath(html) as fname:
397399
# We need the tempfile to avoid JS security issues.
398400
driver.get(f"file:///{fname}")
399-
time.sleep(delay)
401+
WebDriverWait(driver, delay).until(
402+
lambda _driver: _driver.execute_script("return document.readyState")
403+
== "complete"
404+
)
400405
div = driver.find_element("class name", "folium-map")
401406
png = div.screenshot_as_png
402407
driver.quit()

0 commit comments

Comments
 (0)