You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+8-3Lines changed: 8 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -58,13 +58,18 @@ First of all, thanks for your interest in contributing!
58
58
git checkout -b name-of-your-branch
59
59
```
60
60
4. Make change to your local copy of the folium repository
61
-
5. Commit those changes
61
+
5. Make sure the tests pass:
62
+
* in the repository folder do `pip install -e .` (needed for notebook tests)
63
+
* along with all the dependencies install `phantomjs` via `npm install -g phantomjs` or by downloading it from [here](http://phantomjs.org/download.html) and installing manually
64
+
* run `python -m pytest tests`
65
+
* resolve all errors
66
+
6. Commit those changes
62
67
```
63
68
git add file1 file2 file3
64
69
git commit -m 'a descriptive commit message'
65
70
```
66
-
6. Push your updated branch to your fork
71
+
7. Push your updated branch to your fork
67
72
```
68
73
git push origin name-of-your-branch
69
74
```
70
-
7. [Open a pull request](https://help.github.com/articles/creating-a-pull-request/) to the python-visualization/folium
75
+
8. [Open a pull request](https://help.github.com/articles/creating-a-pull-request/) to the python-visualization/folium
0 commit comments