Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-with-buildbot label fails #578

Open
encukou opened this issue Feb 26, 2025 · 1 comment · May be fixed by #579
Open

test-with-buildbot label fails #578

encukou opened this issue Feb 26, 2025 · 1 comment · May be fixed by #579

Comments

@encukou
Copy link
Member

encukou commented Feb 26, 2025

Logs show the following exception after adding a test-with-buildbot label:

2025-02-26 13:41:00+0000 [HTTP11ClientProtocol (BufferingTLSTransport),client] adding changes from web hook
        Traceback (most recent call last):
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
            result = context.run(
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
            return g.throw(self.value.with_traceback(self.tb))
          File "/srv/buildbot/venv/lib/python3.9/site-packages/buildbot/www/change_hook.py", line 106, in getAndSubmitChanges
            changes, src = yield self.getChanges(request)
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
            result = context.run(
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
            return g.throw(self.value.with_traceback(self.tb))
          File "/srv/buildbot/venv/lib/python3.9/site-packages/buildbot/www/change_hook.py", line 171, in getChanges
            changes, src = yield handler.getChanges(request)
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
            result = context.run(
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
            return g.throw(self.value.with_traceback(self.tb))
          File "/srv/buildbot/venv/lib/python3.9/site-packages/buildbot/www/hooks/github.py", line 92, in process
            result = yield handler(payload, event_type)
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
            result = context.run(
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
            return g.throw(self.value.with_traceback(self.tb))
          File "/srv/buildbot/master/custom/pr_testing.py", line 332, in handle_pull_request
            yield self._remove_label_and_comment(payload, label)
          File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2017, in _inlineCallbacks
            result = context.run(gen.send, result)
          File "/srv/buildbot/master/custom/pr_testing.py", line 87, in _remove_label_and_comment
            pr_number = payload["issue"]["number"]
        builtins.KeyError: 'issue'

Looks like that can be ["pull_request"]["number"].
I'll prepare a fix tomorrow if no one beats me to it.
@zware zware linked a pull request Feb 26, 2025 that will close this issue
Open
zware added a commit to zware/buildmaster-config that referenced this issue Feb 26, 2025
@zware
Fix test-with-buildbots label handling
e2c3768 
Fixes python#578, a bug introduced by python#576 for python#327.

I was mislead by the number extraction in another part of the file.
@zware
Copy link
Member

zware commented Feb 26, 2025

Ah, whoops; that was mine :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test-with-buildbots label handling zware/buildmaster-config
2 participants
@encukou @zware