gh-145376: Fix refleak in error path of time_tzset (GH-145477)

eendebakpt · web-flow · commit 3fe7849d9a50 · 2026-03-04T14:21:10.000+01:00
diff --git a/Modules/timemodule.c b/Modules/timemodule.c
@@ -1170,7 +1170,8 @@ time_tzset(PyObject *self, PyObject *unused)
 
     /* Reset timezone, altzone, daylight and tzname */
     if (init_timezone(m) < 0) {
-         return NULL;
+        Py_DECREF(m);
+        return NULL;
     }
     Py_DECREF(m);
     if (PyErr_Occurred())

Original file line number	Diff line number	Diff line change
`@@ -1170,7 +1170,8 @@ time_tzset(PyObject self, PyObject unused)`
`1170`	`1170`
`1171`	`1171`	`/* Reset timezone, altzone, daylight and tzname */`
`1172`	`1172`	`if (init_timezone(m) < 0) {`
`1173`		`- return NULL;`
	`1173`	`+ Py_DECREF(m);`
	`1174`	`+ return NULL;`
`1174`	`1175`	`}`
`1175`	`1176`	`Py_DECREF(m);`
`1176`	`1177`	`if (PyErr_Occurred())`