-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
Open
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-featureA feature request or enhancementA feature request or enhancement
Description
Feature or enhancement
Right now we support typing in several build tools:
Lines 2 to 4 in 6ce60f1
files = | |
Tools/build/compute-changes.py, | |
Tools/build/generate_sbom.py |
I think that some other files / tools from this folder can benefit from being checked with mypy.
I have a PR ready for Tools/build/update_file.py
of parser.c
generation.
What else can be easily typed?
Linked PRs
- gh-133403: Type
Tools/build/update_file.py
and check it withmypy
#133404 - gh-133403: Type Tools/build/verify_ensurepip_wheels.py and check it with mypy #133453
- [3.14] gh-133403: Type
Tools/build/update_file.py
and check it withmypy
(GH-133404) #133603 - [3.13] gh-133403: Type
Tools/build/update_file.py
and check it withmypy
(GH-133404) #133637 - [3.14] gh-133403: Check
Tools/build/verify_ensurepip_wheels.py
with mypy (GH-133453) #133689 - [3.13] gh-133403: Check
Tools/build/verify_ensurepip_wheels.py
with mypy (GH-133453) #133690 - gh-133403: Check
Tools/build/generate-build-details.py
with mypy #133735 - [3.14] gh-133403: Check
Tools/build/generate-build-details.py
with mypy (GH-133735) #133764 - gh-133403: Check
Tools/build/deepfreeze.py
with mypy #133802 - [3.14] gh-133403: Check
Tools/build/deepfreeze.py
with mypy (GH-133802) #134038 - [3.13] gh-133403: Check
Tools/build/deepfreeze.py
with mypy (GH-133802) #134040 - gh-133403: Check
generate_stdlib_module_names
andcheck_extension_modules
with mypy #137546 - [3.14] gh-133403: Check
generate_stdlib_module_names
andcheck_extension_modules
with mypy (GH-137546) #137679 - [3.13] gh-133403: Check
generate_stdlib_module_names
andcheck_extension_modules
with mypy (GH-137546) #137691 - gh-133403: Run
mypy
onTools/build/mypy.ini
changes #137692 - [3.14] gh-133403: Run
mypy
onTools/build/mypy.ini
changes (GH-137692) #137698 - [3.13] gh-133403: Run
mypy
onTools/build/mypy.ini
changes (GH-137692) #137699 - gh-133403: Run
mypy
onTools/build/check_warnings.py
#137700
Metadata
Metadata
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-featureA feature request or enhancementA feature request or enhancement
Projects
Milestone
Relationships
Development
Select code repository
Activity
pythongh-133403: Type `Tools/build/update_file.py` and check it with …
pythongh-133403: Type `Tools/build/update_file.py` and check it with …
pythongh-133403: Type `Tools/build/update_file.py` and check it with …
Tools/build/update_file.py
and check it withmypy
#133404pythongh-133403: Type `Tools/build/update_file.py` and check it with …
sobolevn commentedon May 4, 2025
Tools/build/verify_ensurepip_wheels.py
also has annotations, but it is not checked. Will add in a separate PR, since it requires a bit of modification:sobolevn commentedon May 4, 2025
We should also merge #133405 before any other PR.
Flosckow commentedon May 5, 2025
Can I work on it?
sobolevn commentedon May 5, 2025
@Flosckow sure, you can help with #133403 (comment) I haven't started yet :)
Thank you!
Flosckow commentedon May 5, 2025
Yes, I'll try to do this, the only thing I might be a little slow is this is my first pr in cpython.
sobolevn commentedon May 5, 2025
No worries, I can surely help with any questions you might have. Feel free to ask them :)
48 remaining items
[3.13] pythongh-133403: Check `generate_stdlib_module_names` and `che…
generate_stdlib_module_names
andcheck_extension_modules
with mypy (GH-137546) #137691pythongh-133403: Run `mypy` on `Tools/build/mypy.ini` changes
mypy
onTools/build/mypy.ini
changes #137692gh-133403: Run `mypy` on `Tools/build/mypy.ini` changes (#137692)
[3.14] pythongh-133403: Run `mypy` on `Tools/build/mypy.ini` changes (p…
mypy
onTools/build/mypy.ini
changes (GH-137692) #137698[3.13] pythongh-133403: Run `mypy` on `Tools/build/mypy.ini` changes (p…
mypy
onTools/build/mypy.ini
changes (GH-137692) #137699[3.13] gh-133403: Check `generate_stdlib_module_names` and `check_ext…
[3.13] gh-133403: Run `mypy` on `Tools/build/mypy.ini` changes (GH-13…
pythongh-133403: Run `mypy` on `Tools/build/check_warnings.py`
mypy
onTools/build/check_warnings.py
#137700[3.14] gh-133403: Check `generate_stdlib_module_names` and `check_ext…
[3.14] gh-133403: Run `mypy` on `Tools/build/mypy.ini` changes (GH-13…