Sync submission status / pending status

Author: marcoacierno

backend/submissions/models.py

@@ -109,6 +109,10 @@ class Submission(TimeStampedModel):
 
     objects = SubmissionQuerySet().as_manager()
 
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+        self._original_status = self.status
+
     @property
     def hashid(self):
         return encode_hashid(self.pk)
@@ -185,9 +189,20 @@ def get_admin_url(self):
         )
 
     def save(self, *args, **kwargs):
+        update_fields = kwargs.get("update_fields", None)
+
         if not self.slug:
             self.slug = slugify(self.title.localize("en"))
 
+            if update_fields:
+                update_fields.append("slug")
+
+        if self.pending_status == self._original_status:
+            self.pending_status = self.status
+
+            if update_fields:
+                update_fields.append("pending_status")
+
         return super().save(*args, **kwargs)
 
     def __str__(self):

backend/submissions/tests/test_models.py

@@ -1,10 +1,12 @@
+from submissions.models import Submission
 from submissions.tests.factories import SubmissionFactory
 from pytest import mark
 
 from i18n.strings import LazyI18nString
 
+pytestmark = mark.django_db
+
 
-@mark.django_db
 def test_slug_is_not_regenerated_when_changing_title():
     submission = SubmissionFactory(title=LazyI18nString({"en": "hello", "it": "hell"}))
     assert submission.slug == "hello"
@@ -15,3 +17,33 @@ def test_slug_is_not_regenerated_when_changing_title():
     submission.refresh_from_db()
 
     assert submission.slug == "hello"
+
+
+def test_syncs_pending_status_when_changing_status():
+    submission = SubmissionFactory(
+        status=Submission.STATUS.accepted,
+        pending_status=Submission.STATUS.accepted,
+    )
+
+    submission.status = Submission.STATUS.rejected
+    submission.save()
+
+    submission.refresh_from_db()
+
+    assert submission.status == Submission.STATUS.rejected
+    assert submission.pending_status == Submission.STATUS.rejected
+
+
+def test_leaves_pending_status_unchanged_if_different():
+    submission = SubmissionFactory(
+        status=Submission.STATUS.proposed,
+        pending_status=Submission.STATUS.rejected,
+    )
+
+    submission.status = Submission.STATUS.waiting_list
+    submission.save()
+
+    submission.refresh_from_db()
+
+    assert submission.status == Submission.STATUS.waiting_list
+    assert submission.pending_status == Submission.STATUS.rejected