Add character limitations for all open question fields

Author: estyxx

backend/api/grants/mutations.py

@@ -69,6 +69,11 @@ def validate(self, conference: Conference, user: User) -> GrantErrors:
             "departure_country": 100,
             "nationality": 100,
             "departure_city": 100,
+            "why": 1000,
+            "python_usage": 700,
+            "been_to_other_events": 500,
+            "community_contribution": 900,
+            "notes": 350,
         }
         for field, max_length in max_length_fields.items():
             value = getattr(self, field, "")

backend/api/grants/tests/test_send_grant.py

@@ -243,6 +243,11 @@ def test_cannot_send_grant_outside_allowed_values(
         departureCountry="Very long location" * 50,
         nationality="Freedonia" * 50,
         departureCity="Emerald City " * 50,
+        why="Very long why" * 100,
+        pythonUsage="Very long python usage" * 100,
+        beenToOtherEvents="Very long been to other events" * 100,
+        communityContribution="Very long community contribution" * 100,
+        notes="Very long notes" * 100,
     )
 
     assert response["data"]["sendGrant"]["__typename"] == "GrantErrors"
@@ -258,6 +263,21 @@ def test_cannot_send_grant_outside_allowed_values(
     assert response["data"]["sendGrant"]["errors"]["validationDepartureCity"] == [
         "departure_city: Cannot be more than 100 chars"
     ]
+    assert response["data"]["sendGrant"]["errors"]["validationWhy"] == [
+        "why: Cannot be more than 1000 chars"
+    ]
+    assert response["data"]["sendGrant"]["errors"]["validationPythonUsage"] == [
+        "python_usage: Cannot be more than 700 chars"
+    ]
+    assert response["data"]["sendGrant"]["errors"]["validationBeenToOtherEvents"] == [
+        "been_to_other_events: Cannot be more than 500 chars"
+    ]
+    assert response["data"]["sendGrant"]["errors"][
+        "validationCommunityContribution"
+    ] == ["community_contribution: Cannot be more than 900 chars"]
+    assert response["data"]["sendGrant"]["errors"]["validationNotes"] == [
+        "notes: Cannot be more than 350 chars"
+    ]
 
 
 def test_cannot_send_grant_with_empty_values(

frontend/src/components/grant-form/index.tsx

@@ -544,6 +544,7 @@ export const GrantForm = ({
                 required={true}
                 placeholder={inputPlaceholderText}
                 errors={getErrors("why")}
+                maxLength={1000}
               />
             </InputWrapper>
           </Grid>
@@ -658,6 +659,7 @@ export const GrantForm = ({
                 required={true}
                 placeholder={inputPlaceholderText}
                 errors={getErrors("pythonUsage")}
+                maxLength={700}
               />
             </InputWrapper>
 
@@ -676,6 +678,7 @@ export const GrantForm = ({
                 required={true}
                 errors={getErrors("beenToOtherEvents")}
                 placeholder={inputPlaceholderText}
+                maxLength={500}
               />
             </InputWrapper>
 
@@ -694,6 +697,7 @@ export const GrantForm = ({
                 required={false}
                 errors={getErrors("communityContribution")}
                 placeholder={inputPlaceholderText}
+                maxLength={900}
               />
             </InputWrapper>
           </Grid>
@@ -739,6 +743,7 @@ export const GrantForm = ({
                 {...textarea("notes")}
                 errors={getErrors("notes")}
                 placeholder={inputPlaceholderText}
+                maxLength={350}
               />
             </InputWrapper>
           </Grid>
@@ -753,7 +758,9 @@ export const GrantForm = ({
         photoRequired={false}
         getParticipantValidationError={(field) =>
           getErrors(
-            `validationSpeaker${field[0].toUpperCase()}${field.substring(1)}` as any,
+            `validationSpeaker${field[0].toUpperCase()}${field.substring(
+              1,
+            )}` as any,
           )
         }
         showPhotoField={false}