Skip to content

Commit 9e6ef50

Browse files
committed
changes
1 parent 839ffde commit 9e6ef50

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

backend/organizers/tests/factories.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ class Meta:
99
model = Organizer
1010

1111
name = factory.Faker("word")
12-
slug = factory.Faker("word")
12+
slug = factory.Sequence(lambda n: "slug{}".format(n))

backend/visa/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@ def grant_approved_type(self):
114114
def user_grant(self):
115115
return Grant.objects.for_conference(self.conference).of_user(self.user).first()
116116

117-
def get_role(self):
117+
@cached_property
118+
def role(self):
118119
user = self.user
119120

120121
if not user:

backend/visa/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def _render_content(content, invitation_letter_request, config):
140140
"date_of_birth": invitation_letter_request.date_of_birth,
141141
"passport_number": invitation_letter_request.passport_number,
142142
"embassy_name": invitation_letter_request.embassy_name,
143-
"role": invitation_letter_request.get_role(),
143+
"role": invitation_letter_request.role,
144144
"grant_approved_type": invitation_letter_request.grant_approved_type,
145145
"has_accommodation_via_grant": invitation_letter_request.has_accommodation_via_grant(),
146146
"has_travel_via_grant": invitation_letter_request.has_travel_via_grant(),

backend/visa/tests/test_models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def test_request_on_behalf_of_other():
1919
assert request.on_behalf_of_other
2020
assert request.email == "[email protected]"
2121
assert request.user is None
22-
assert request.get_role() == "Attendee"
22+
assert request.role == "Attendee"
2323

2424
# With matching user, it is found
2525
user = UserFactory(email="[email protected]")
@@ -74,7 +74,7 @@ def test_role_for_speakers():
7474
status=Submission.STATUS.accepted,
7575
)
7676

77-
assert request.get_role() == "Speaker"
77+
assert request.role == "Speaker"
7878

7979

8080
def test_schedule_processing(django_capture_on_commit_callbacks, mocker):

0 commit comments

Comments
 (0)