change

Author: marcoacierno

backend/pycon/storages.py

@@ -62,18 +62,14 @@ def generate_upload_url(self, file_obj):
 
 class PrivateCustomS3Boto3Storage(CustomS3Boto3Storage):
     default_acl = "private"
+    custom_domain = None
+    querystring_auth = True
 
     def get_object_parameters(self, name):
         params = super().get_object_parameters(name)
         params.pop("CacheControl", None)
         return params
 
-    def get_default_settings(self):
-        settings = super().get_default_settings()
-        settings["custom_domain"] = None
-        settings["querystring_auth"] = True
-        return settings
-
 
 class CustomInMemoryStorage(InMemoryStorage):
     is_remote = False

backend/pycon/tests/test_storage.py

@@ -51,10 +51,3 @@ def test_private_storage_removes_cache_control_params():
     storage = PrivateCustomS3Boto3Storage()
     params = storage.get_object_parameters("test.pdf")
     assert "CacheControl" not in params
-
-
-def test_private_storage_removes_public_settings():
-    storage = PrivateCustomS3Boto3Storage()
-    params = storage.get_default_settings()
-    assert params["custom_domain"] is None
-    assert params["querystring_auth"]