Run claude for PR reviews #4511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marcoacierno
requested review from
pythonitaliabot2
and removed request for
pythonitaliabot2
marcoacierno
requested review from
pythonitaliabot2
and removed request for
pythonitaliabot2
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| steps: | ||
| - name: Debug | ||
| run: | | ||
| echo "github.event: ${{ fromJSON(github.event) }}" |
Check failure
Code scanning / CodeQL
Code injection Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 days ago
To fix the code injection vulnerability, we should avoid direct interpolation of user-controlled values into shell commands. Specifically, instead of using echo "github.event: ${{ fromJSON(github.event) }}" directly, assign the value of ${{ toJSON(github.event) }} to an environment variable, then access it in the shell step using native shell variable expansion (e.g., "$EVENT"). This prevents any shell metacharacters in the event payload from being evaluated/executed by the shell.
- Edit the debug job's step that currently echoes
github.eventusing expression interpolation. - Move the event value assignment to an environment variable via the
env:block. - Access that variable using
$EVENTin the shell command, thus neutralizing code injection risks. - Use
toJSONinstead offromJSONfor proper string formatting (as in GitHub Actions best practices for dumping event payloads).
Suggested changeset
1
.github/workflows/claude.yml
| @@ -17,8 +17,10 @@ | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Debug | ||
| env: | ||
| EVENT: ${{ toJSON(github.event) }} | ||
| run: | | ||
| echo "github.event: ${{ fromJSON(github.event) }}" | ||
| echo "github.event: $EVENT" | ||
| claude: | ||
| if: | | ||
| (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) || |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ToDo