Skip to content

Commit 190f8fa

Browse files
Kaixhinapaszke
authored andcommitted
Prevent 2 forward passes with detach
1 parent ec4802c commit 190f8fa

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

dcgan/main.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,9 @@ def forward(self, input):
213213
# train with fake
214214
noise.data.resize_(batch_size, nz, 1, 1)
215215
noise.data.normal_(0, 1)
216-
fake = netG(noise).detach()
216+
fake = netG(noise)
217217
label.data.fill_(fake_label)
218-
output = netD(fake)
218+
output = netD(fake.detach())
219219
errD_fake = criterion(output, label)
220220
errD_fake.backward()
221221
D_G_z1 = output.data.mean()
@@ -227,8 +227,6 @@ def forward(self, input):
227227
###########################
228228
netG.zero_grad()
229229
label.data.fill_(real_label) # fake labels are real for generator cost
230-
noise.data.normal_(0, 1)
231-
fake = netG(noise)
232230
output = netD(fake)
233231
errG = criterion(output, label)
234232
errG.backward()

0 commit comments

Comments
 (0)