Skip to content

Commit dd16790

Browse files
authored
Revert #13526 and #13640 (#13684)
Revert #13526 and #13640 to land as one internally
1 parent c455f1b commit dd16790

File tree

8 files changed

+36
-253
lines changed

8 files changed

+36
-253
lines changed

extension/android/BUCK

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ non_fbcode_target(_kind = fb_android_library,
1010
"executorch_android/src/main/java/org/pytorch/executorch/DType.java",
1111
"executorch_android/src/main/java/org/pytorch/executorch/EValue.java",
1212
"executorch_android/src/main/java/org/pytorch/executorch/ExecuTorchRuntime.java",
13-
"executorch_android/src/main/java/org/pytorch/executorch/ExecutorchRuntimeException.java",
1413
"executorch_android/src/main/java/org/pytorch/executorch/MethodMetadata.java",
1514
"executorch_android/src/main/java/org/pytorch/executorch/Module.java",
1615
"executorch_android/src/main/java/org/pytorch/executorch/Tensor.java",

extension/android/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ executorch_target_link_options_shared_lib(executorch)
7171

7272
add_library(
7373
executorch_jni SHARED jni/jni_layer.cpp jni/log.cpp jni/jni_layer_runtime.cpp
74-
jni/jni_helper.cpp
7574
)
7675

7776
set(link_libraries)

extension/android/executorch_android/src/main/java/org/pytorch/executorch/ExecutorchRuntimeException.java

Lines changed: 0 additions & 125 deletions
This file was deleted.

extension/android/jni/BUCK

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ non_fbcode_target(_kind = executorch_generated_lib,
2828

2929
non_fbcode_target(_kind = fb_android_cxx_library,
3030
name = "executorch_jni",
31-
srcs = ["jni_layer.cpp", "log.cpp", "jni_layer_runtime.cpp", "jni_helper.cpp"],
31+
srcs = ["jni_layer.cpp", "log.cpp", "jni_layer_runtime.cpp"],
3232
allow_jni_merging = False,
3333
compiler_flags = ET_JNI_COMPILER_FLAGS,
3434
soname = "libexecutorch.$(ext)",
@@ -49,7 +49,7 @@ non_fbcode_target(_kind = fb_android_cxx_library,
4949

5050
non_fbcode_target(_kind = fb_android_cxx_library,
5151
name = "executorch_jni_full",
52-
srcs = ["jni_layer.cpp", "log.cpp", "jni_layer_runtime.cpp", "jni_helper.cpp"],
52+
srcs = ["jni_layer.cpp", "log.cpp", "jni_layer_runtime.cpp"],
5353
allow_jni_merging = False,
5454
compiler_flags = ET_JNI_COMPILER_FLAGS,
5555
soname = "libexecutorch.$(ext)",
@@ -71,7 +71,7 @@ non_fbcode_target(_kind = fb_android_cxx_library,
7171

7272
non_fbcode_target(_kind = fb_android_cxx_library,
7373
name = "executorch_training_jni",
74-
srcs = ["jni_layer.cpp", "log.cpp", "jni_layer_runtime.cpp", "jni_layer_training.cpp", "jni_helper.cpp"],
74+
srcs = ["jni_layer.cpp", "log.cpp", "jni_layer_runtime.cpp", "jni_layer_training.cpp"],
7575
allow_jni_merging = False,
7676
compiler_flags = ET_JNI_COMPILER_FLAGS + [
7777
"-DEXECUTORCH_BUILD_EXTENSION_TRAINING",
@@ -102,7 +102,6 @@ non_fbcode_target(_kind = fb_android_cxx_library,
102102
"jni_layer.cpp",
103103
"jni_layer_llama.cpp",
104104
"jni_layer_runtime.cpp",
105-
"jni_helper.cpp",
106105
],
107106
allow_jni_merging = False,
108107
compiler_flags = ET_JNI_COMPILER_FLAGS + [
@@ -146,14 +145,9 @@ runtime.export_file(
146145
name = "jni_layer_runtime.cpp",
147146
)
148147

149-
runtime.export_file(
150-
name = "jni_helper.cpp",
151-
)
152-
153148
runtime.cxx_library(
154149
name = "jni_headers",
155150
exported_headers = [
156151
"jni_layer_constants.h",
157-
"jni_helper.h",
158152
]
159153
)

extension/android/jni/jni_helper.cpp

Lines changed: 0 additions & 34 deletions
This file was deleted.

extension/android/jni/jni_helper.h

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)