Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] break_when_all_done in env.rollout() #2355

Open
vmoens opened this issue Aug 4, 2024 · 0 comments · Fixed by #2381
Open

[Feature Request] break_when_all_done in env.rollout() #2355

vmoens opened this issue Aug 4, 2024 · 0 comments · Fixed by #2381
Assignees
@vmoens
Labels
enhancement New feature or request

Comments

@vmoens
Copy link
Contributor

vmoens commented Aug 4, 2024

Feature description

We should be able to ask a rollout to stop once all sub-envs are done.

If partial steps are available, we could discard those envs who are done.

If not, we should reset them and run (not ideal).
@vmoens vmoens added the enhancement New feature or request label Aug 4, 2024
@vmoens vmoens self-assigned this Aug 4, 2024
This was referenced Aug 4, 2024
Open
Open
@vmoens vmoens linked a pull request Aug 8, 2024 that will close this issue
[Feature] break_when_all_done in rollout #2381
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmoens vmoens

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] break_when_all_done in rollout pytorch/rl
1 participant
@vmoens