Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the TensorDict structure of the return of the _step() function for a multi agent environment #2425

Open
1 task done
zoetsekas opened this issue Sep 8, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@zoetsekas
Copy link

zoetsekas commented Sep 8, 2024

Motivation

It is not very clear what should be the structure of TensorDict of the return of the _step() function for a multi agent environment.

If there are two agents A and B and they are in separate groups, what would be the structure of the TensorDict that is returned by the _step() function?

Solution

Update the documentation and provide an example of a multi agent environment that is written natively in torchrl and it is not translated from other frameworks like petting zoo

Checklist

  • I have checked that there is no similar issue in the repo (required)

@matteobettini

@zoetsekas zoetsekas added the enhancement New feature or request label Sep 8, 2024
@matteobettini
Copy link
Contributor

Hello! thanks for opening this!

We currently have this doc

https://pytorch.org/rl/stable/reference/envs.html#multi-agent-environments

but I agree that it needs to be updated to describe a more general situation wuith multiple agent groups

@N00bcak
Copy link
Contributor

N00bcak commented Sep 11, 2024

Let me have a crack at this.
This page currently has a TensorDict structure that we could probably make into a pattern for multiagent envs.

Give me a little time though; I'm drowning in assignments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants