Type-annotate dtypes.promote() (#507)

Yuan Chao Chou · facebook-github-bot · commit 74d0df7de77e · 2022-10-13T12:55:34.000-07:00
Summary: Pull Request resolved: #507 `dtypes.promote()` is not typed. Fix it Reviewed By: wenleix Differential Revision: D40330862 fbshipit-source-id: 343ff4398b42f3277df3f1779f16a455391be9e4
diff --git a/torcharrow/dtypes.py b/torcharrow/dtypes.py
@@ -364,7 +364,7 @@ def infer_dype_from_callable_hint(
 ]
 
 
-def promote(l, r):
+def promote(l: DType, r: DType) -> ty.Optional[DType]:
     assert is_boolean_or_numerical(l) and is_boolean_or_numerical(r)
 
     lt = l.typecode

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ def infer_dype_from_callable_hint(`
`364`	`364`	`]`
`365`	`365`
`366`	`366`
`367`		`-def promote(l, r):`
	`367`	`+def promote(l: DType, r: DType) -> ty.Optional[DType]:`
`368`	`368`	`assert is_boolean_or_numerical(l) and is_boolean_or_numerical(r)`
`369`	`369`
`370`	`370`	`lt = l.typecode`