Skip to content

Commit 5b26395

Browse files
committed
[simple_fsdp] Turn on bucketing by default
ghstack-source-id: 02c9bdb Pull Request resolved: #2103
1 parent 53e949c commit 5b26395

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

torchtitan/experiments/simple_fsdp/backend.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def get_compile_backend_with_passes(
5252
def aot_eager_autobucketing_reordering_pass(
5353
gm: torch.fx.GraphModule, example_inputs: Any
5454
) -> torch.fx.GraphModule:
55-
schedule_overlap_bucketing(gm)
55+
schedule_overlap_bucketing(gm, collective_bucketing=True)
5656
gm.recompile()
5757
return gm
5858

@@ -67,7 +67,11 @@ def aot_eager_autobucketing_reordering_pass(
6767
def inductor_autobucketing_reordering_pass(
6868
gm: torch.fx.Graph,
6969
) -> torch.fx.GraphModule:
70-
return schedule_overlap_bucketing(gm.owning_module)
70+
return schedule_overlap_bucketing(
71+
gm.owning_module,
72+
collective_bucketing=True,
73+
insert_overlap_deps=True,
74+
)
7175

7276
dist_opts.insert_overlap_deps = True
7377
torch._inductor.config.reorder_for_peak_memory = False

0 commit comments

Comments
 (0)