Skip to content

Commit 9e43a67

Browse files
committed
fix if-check
1 parent a23ab5b commit 9e43a67

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

torchtitan/distributed/pipeline_parallel.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def build_pipeline_schedule(
100100

101101
if (
102102
job_config.parallelism.pipeline_parallel_expert_parallel_overlap
103-
and job_config.parallelism.pipeline_parallel_schedule == "dualpipev"
103+
and isinstance(schedule, ScheduleDualPipeV)
104104
):
105105
schedule.register_custom_function(OVERLAP_F_B, overlap_callback)
106106

@@ -466,6 +466,7 @@ def overlap_callback(action: _Action, ctx: _PipelineContext):
466466
Custom callback for OVERLAP_F_B computation that allows expert parallel communication
467467
and pipeline parallel computation to overlap.
468468
"""
469+
print("calling into overlap callback")
469470
schedule = ctx.schedule_ref
470471
assert isinstance(schedule, _PipelineScheduleRuntime)
471472
stage_index_to_stage: dict[int, _PipelineStageBase] = {

0 commit comments

Comments
 (0)