Skip to content

Commit 6f39c6e

Browse files
kiukchungfacebook-github-bot
authored andcommitted
Fix broken docs-build by pinning apache-airflow==2.10.2 (#1033)
Summary: Pull Request resolved: #1033 `apache-airflow>2.6.3` (installed in `docs/requirements.txt`) transitively brings in `opentelemetry` which depends on `protobuf>=4.x`. This version of `protobuf` conflicts with the one required by `kfp==1.8.x` (`protobuf <= 3.20.x`). What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
1 parent d633108 commit 6f39c6e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/doc-build.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,15 @@ jobs:
2020
architecture: x64
2121
- name: Checkout TorchX
2222
uses: actions/checkout@v2
23+
- name: Install TorchX
24+
run: |
25+
pip install -e .[dev]
2326
- name: Install Dependencies
2427
run: |
2528
set -eux
2629
sudo apt-get update
2730
sudo apt-get install -y pandoc
28-
pip install -e .[dev]
2931
pip install -r docs/requirements.txt
30-
- name: Install TorchX
31-
run: |
32-
python setup.py develop
3332
- name: Start Airflow
3433
run: |
3534
# start airflow in background

docs/requirements.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,7 @@ jupytext
1010
ipython_genutils
1111
# https://github.com/jupyter/nbconvert/issues/1736
1212
jinja2>=3.1.4
13-
apache-airflow
13+
# higher versions of airflow brings in opentelemetry which depends
14+
# a version of protobuf incompatible with pinned kfp in dev-requirements.txt
15+
apache-airflow==2.10.2
16+
protobuf==3.20.3

0 commit comments

Comments
 (0)