Skip to content

ray scheduler either appends a random string to my specified app_id, or ignores it entirely #631

Open
@starpit

Description

@starpit

🐛 Bug

When I submit, e.g.

torchx run -s ray -cfg app_id=myOwnUniqueString ...

it seems that the ray scheduler always appends a "unique" 64-bit suffix to whatever I specify. I could understand doing this for cases where an app_id was not explicitly provided from the CLI, but if I am giving you an app_id to use, I kinda expect you to use it?

Using the utils.python builtin, at least only a random string is tacked on the end of what I provide. When using the utils.sh builtin, none of what I specify in the -cfg app_id=... actually appears in the resulting ray job id.

Module (check all that applies):

  • torchx.spec
  • torchx.component
  • torchx.apps
  • torchx.runtime
  • torchx.cli
  • torchx.schedulers
  • torchx.pipelines
  • torchx.aws
  • torchx.examples
  • other

To Reproduce

Steps to reproduce the behavior:

  1. torchx run -s ray -cfg app_id=somethingSomething
  2. observe that the ray job has a job_id of somethingSomething-64bitsofadditionalhex

Expected behavior

I think the ray scheduler should use what it is given, and only append random bits if it is using its own default value for app_id.

Environment

  • torchx version (e.g. 0.1.0rc1): 0.2.0
  • Python version: any
  • OS (e.g., Linux): any
  • How you installed torchx (conda, pip, source, docker): pip
  • Docker image and tag (if using docker): n/a
  • Git commit (if installed from source): n/a
  • Execution environment (on-prem, AWS, GCP, Azure etc): n/a
  • Any other relevant information: n/a

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestrayRelated to the ray scheduler

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions