Skip to content

Remove deprecated GetDefaultDevice(). #9724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated GetDefaultDevice(). #9724

wants to merge 1 commit into from

Conversation

@ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Nov 26, 2025

This PR removes the deprecated GetDefaultDevice(), and renames SafeGetDefaultDevice(), removing its Safe prefix. Then, it also adapts all GetDefaultDevice() call sites, so as to handle the returned status-like instance appropriately.

Key Changes:

  • Remove the deprecated GetDefaultDevice()
  • Rename SafeGetDefaultDevice() to GetDefaultDevice()
  • Handle the returned status-like instance of all GetDefaultDevice() call sites
  • Use [[deprecated(...)]] instead of ABSL_DEPRECATED for TryGetXlaTensor() function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ysiraichi