fix issue 138 get element count not throw exception and add keyword drag and drop (#143)

* Add drag and drop keywords

* Fix support selenium locator

* Return 0 if get elements count not found any items

* Fix count not found items return 0 instead of throw exception

* Add document for mouse drag limitation.
Fixed set timeout keywords

Co-authored-by: DESKTOP\atthaboon.s <[email protected]>

Author: atthaboon

Examples/alert-handler/alert-handler.robot

@@ -23,7 +23,6 @@ Dismiss alert
     ...    Click Element    id=alert_confirm
     Click Element    id:get_ajax
 
-    
 *** Keywords ***
 Open browser to test page
     ${BROWSER} =     Get variable value    ${BROWSER}     ${DEFAULT_BROWSER}

Examples/form-handler/element-properties.robot

@@ -10,9 +10,14 @@ ${HOME_PAGE_URL}    http://127.0.0.1:7272/basic-html-elements.html
 
 
 *** Test Cases ***
-Count element
+Count elements
     ${No of h2} =    Get Element Count    css=h2
     Should Be Equal As Numbers    14    ${No of h2}
+    
+Count non existing element
+    Set Timeout    1s
+    ${No of h2} =    Get Element Count    css=Hnotexisting
+    Should Be Equal As Numbers    0    ${No of h2}
 
 Get element attribute
     ${type value} =   Get Element Attribute    id=alert_confirm    type

Examples/input/mouse.robot

@@ -5,7 +5,7 @@ Test Teardown    Close All Browser
 Suite Teardown    Close Puppeteer
 
 *** Variables ***
-${DEFAULT_BROWSER}    firefox
+${DEFAULT_BROWSER}    chrome
 ${HOME_PAGE_URL}    http://127.0.0.1:7272/basic-html-elements.html
 
 
@@ -22,7 +22,11 @@ Mouse drag
     Mouse Down    id=ball
     Mouse Move    40    50
     Mouse Up        
-
+   
+Mouse drag and drop
+    [Tags]    Ignore_firefox    Ignore_ptchrome
+    Drag And Drop    id=ball    id=dropdown-menu
+    
 *** Keywords ***
 Open browser to test page
     ${BROWSER} =     Get variable value    ${BROWSER}    ${DEFAULT_BROWSER}

PuppeteerLibrary/keywords/element.py

@@ -194,7 +194,10 @@ def element_text_should_not_be(self, locator, expected, ignore_case=False):
     def get_element_count(self, locator):
         """ Returns the number of elements matching ``locator``.
         """
-        return len(self.loop.run_until_complete(self.get_async_keyword_group().find_elements(locator)))
+        try:
+            return len(self.loop.run_until_complete(self.get_async_keyword_group().find_elements(locator)))
+        except:
+            return 0
 
     ##############################
     # Scrolling

PuppeteerLibrary/keywords/mouseevent.py

@@ -34,6 +34,17 @@ def mouse_up(self):
     @keyword
     def mouse_move(self, x, y):
         """Move mouse to position x, y.
+
+        *Limitation* Drag event only support for css / id locator. Not support for xpath locator or chain locator.
         """
         self.info(f"Mouse move to x: '{x}', y: '{y}'.")
         return self.loop.run_until_complete(self.get_async_keyword_group().mouse_move(x, y))
+
+    @keyword
+    def drag_and_drop(self, src_locator, desc_locator):
+        """Drag item form sort locator to destination locator
+
+        *Limitation* Drag event only support for css / id locator. Not support for xpath locator or chain locator.
+        """
+        self.info(f"Draf from '{src_locator}' to '{desc_locator}'.")
+        return self.loop.run_until_complete(self.get_async_keyword_group().drag_and_drop(src_locator, desc_locator))

PuppeteerLibrary/keywords/utility.py

@@ -26,7 +26,7 @@ def set_timeout(self, timeout):
 
         """
         orig_timeout = self.ctx.timeout
-        self.ctx.get_current_library_context().timeout = timestr_to_secs(timeout)
+        self.ctx.get_current_library_context().set_default_timeout(timestr_to_secs(timeout))
         self.info('Original timeout is ' + str(orig_timeout) + ' seconds')
         return orig_timeout
 

PuppeteerLibrary/library_context/ilibrary_context.py

@@ -25,6 +25,10 @@ async def stop_server(self):
     def is_server_started(self) -> bool:
         pass
 
+    @abstractmethod
+    def set_default_timeout(self, timeout):
+        pass
+
     @abstractmethod
     async def create_new_page(self, options: dict={}) -> BasePage:
         pass

PuppeteerLibrary/playwright/async_keywords/playwright_mouseevent.py

@@ -1,3 +1,4 @@
+from PuppeteerLibrary.locators import SelectorAbstraction
 from PuppeteerLibrary.utils.coverter import str2int, str2str
 import time
 from robot.libraries.BuiltIn import BuiltIn
@@ -30,3 +31,8 @@ async def mouse_move(self, x, y):
         x = str2int(x)
         y = str2int(y)
         await self.library_ctx.get_current_page().get_page().mouse.move(x, y)
+
+    async def drag_and_drop(self, src_locator, desc_locator):
+        src_locator_value = SelectorAbstraction.get_selector(src_locator)
+        desc_locator_value = SelectorAbstraction.get_selector(desc_locator)
+        await self.library_ctx.get_current_page().get_page().drag_and_drop(src_locator_value, desc_locator_value)

PuppeteerLibrary/playwright/playwright_context.py

@@ -74,7 +74,6 @@ async def start_server(self, options: dict={}):
             self.browser = await self.playwright.firefox.launch(
                 headless=merged_options['headless'])
         self.browser.accept_downloads = True
-        # self.current_context = await self.browser.new_context()
 
     async def stop_server(self):
         await self.playwright.stop()
@@ -85,6 +84,10 @@ def is_server_started(self) -> bool:
             return True
         return False
 
+    def set_default_timeout(self, timeout):
+        self.timeout = timeout
+        self.get_current_page().get_page().set_default_timeout(timeout * 1000)
+
     async def create_new_page(self, options: dict={}) -> BasePage:
         device_options = {
             'accept_downloads': True,
@@ -174,3 +177,4 @@ def _reset_context(self):
     def _reset_server_context(self):
         self._reset_context()
         self.playwright = None
+    

PuppeteerLibrary/puppeteer/async_keywords/puppeteer_mouseevent.py

@@ -26,3 +26,6 @@ async def mouse_move(self, x, y):
         x = str2int(x)
         y = str2int(y)
         await self.library_ctx.get_current_page().get_page().mouse.move(x, y)
+
+    async def drag_and_drop(self, src_locator, desc_locator):
+        raise Exception('Not supported for ptchrome. Please use pwchrome')