Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamWriter-like API when reading #1284

Open
thomascharbonnel opened this issue Jul 22, 2022 Discussed in #1276 · 2 comments · May be fixed by #1291
Open

StreamWriter-like API when reading #1284

thomascharbonnel opened this issue Jul 22, 2022 Discussed in #1276 · 2 comments · May be fixed by #1291

Comments

@thomascharbonnel
Copy link
Contributor

Discussed in #1276

Originally posted by thomascharbonnel July 11, 2022
Hello,

First, thanks a lot for the amount of work you have put into this library, it's great! I'm happy to finally have an alternative to Apache POI!

I have a question that is somewhat related to an issue that was open earlier. Currently, excelize has a "stream reader" API using f.Rows() and row.Columns. Now, what Columns() returns isn't identical to what is expected when writing to a worksheet using StreamWriter. By that i mean that Columns() will only give you the cells' values, not all its attributes (value, style, formula), while on the other hand, streamwriter allows you to write the value+style+formula.
I'd like to create an API similar to StreamWriter when reading (ie. i'd like to be able to read the value+style+formula at the same time when reading a cell), do you think that would be a good idea? If yes, any pointers to get started?

Thank you! 🙏

thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Jul 25, 2022
qax-os#1284 WIP
8fc6e6f
@thomascharbonnel
Copy link
Contributor Author

thomascharbonnel commented Jul 25, 2022 •
edited
Loading

Hi @xuri,

This is a WIP for this feature: master...thomascharbonnel:excelize:1284-streamreader-return-cell(so some of the tests aren't passing yet)

I've reused StreamWriter's Cell structure, though it might make sense to create a separate structure?
I was thinking, in order to keep the ability for users to get a string with the proper excel styling, to define the appropriate String() on Cell.

Please feel free to suggest improvements if you have any in mind! Thank you!

thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Jul 25, 2022
qax-os#1284 WIP
1da8808
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Jul 27, 2022
qax-os#1284 WIP add formula
764eb44
@thomascharbonnel thomascharbonnel linked a pull request Jul 27, 2022 that will close this issue
Draft
10 tasks
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Jul 27, 2022
qax-os#1284 WIP
2a2ca84
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Jul 27, 2022
qax-os#1284 WIP add formula
964c563
@xuri
Copy link
Member

xuri commented Jul 27, 2022

Thanks for your issue. The stream function was created for reading and writing a large data efficiently, at that time, I think maybe getting the value of the cell is the most typical scenario, getting the other attributes of the cell was not very usually, user can get these attributes by normal mode functions, so I have not implemented this feature.

I reconsider this design at this time, and I've left some comments for the draft PR.

thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 1, 2022
qax-os#1284 WIP
7fd5a67
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 1, 2022
qax-os#1284 WIP add formula
1fd051c
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 4, 2022
qax-os#1284 WIP
234c554
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 4, 2022
qax-os#1284 WIP add formula
4db31ef
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 4, 2022
qax-os#1284 WIP
5c522ae
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 4, 2022
qax-os#1284 WIP add formula
9d0b21f
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 11, 2022
qax-os#1284 WIP
218e350
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 11, 2022
qax-os#1284 WIP add formula
0b3a243
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 17, 2022
qax-os#1284 WIP
483966b
thomascharbonnel pushed a commit to thomascharbonnel/excelize that referenced this issue Aug 17, 2022
qax-os#1284 WIP add formula
cae714f
@xuri xuri linked a pull request Aug 26, 2022 that will close this issue
Draft #1284 streamreader return cell #1291
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft #1284 streamreader return cell thomascharbonnel/excelize
2 participants
@xuri @thomascharbonnel